Bug 790293 - RequestTimer calls exception() incorrectly
Summary: RequestTimer calls exception() incorrectly
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: lab controller
Version: 0.8
Hardware: Unspecified
OS: Unspecified
medium
medium vote
Target Milestone: ---
Assignee: Raymond Mancy
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-14 06:41 UTC by Raymond Mancy
Modified: 2019-05-22 13:41 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-04-12 01:39:24 UTC

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Raymond Mancy 2012-02-14 06:41:02 UTC 
in proxy.py in RequestTimer class the offending line is:

  logger.exception()

It should be:
  logger.exception(str(e))

This causes any issue with the thread that keep the proxy process logged in,
as if there is an exception it will not log and recover as it is supposed to.
Comment 1 Dan Callaghan 2012-02-14 23:57:08 UTC 
Better would be something like

    logger.exception('Failed to login to Beaker server')

The .exception() method already adds the complete stack trace from the exception so str(e) is not necessary.
Comment 2 Raymond Mancy 2012-04-12 01:39:24 UTC 
This was already pushed on the 0.8.1 branch as a hotfix
Note You need to log in before you can comment on or make changes to this bug.