Bug 790532 - node update might fail because of old grub usage
Summary: node update might fail because of old grub usage
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-node
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Fabian Deutsch
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-14 19:08 UTC by Fabian Deutsch
Modified: 2016-04-26 17:26 UTC (History)
6 users (show)

Fixed In Version: 2.4.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-14 13:35:28 UTC
oVirt Team: ---


Attachments (Terms of Use)

Description Fabian Deutsch 2012-02-14 19:08:38 UTC
Description of problem:
The following line is AFAIU not valid for legacy grub
http://gerrit.ovirt.org/gitweb?p=ovirt-node.git;a=blob;f=scripts/ovirt-post#l85

This could lead to an upgrade failure of the node.

Comment 1 Alan Pevec 2012-03-22 20:42:49 UTC
After systemd patchset landed, "savedefault" is now at
http://gerrit.ovirt.org/gitweb?p=ovirt-node.git;a=blob;f=scripts/ovirt-init-functions.sh;h=e1a09df64844c3726ac1241e02697e19d1cd6226;hb=HEAD#l1262

savedefault should be removed, and I think intended behavior (fallback after image update fails to boot) is default in Fedora grub2, there's GRUB_DEFAULT=saved in /etc/default/grub

But not sure if this has been tested with ovirt-node after migration to grub2?

Comment 2 Mike Burns 2012-03-23 11:53:41 UTC
We need to conditionalize that statement then.  savedefault is still valid for distros using legacy grub, some of which we still use.

Comment 3 Mike Burns 2012-03-23 13:53:34 UTC
defer to 2.4 so we can test fallback

Comment 4 Fabian Deutsch 2012-05-07 12:47:21 UTC
The following patch just executes the lagacy grub command if no grub2 is found.
http://gerrit.ovirt.org/4173

Currently the code just greps the line for the GRUB_DEFAULT param and adds it to the log file.
It might make sense to additionally update this param if needed.


Note You need to log in before you can comment on or make changes to this bug.