Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 791245

Summary: [ovirt] [vdsm] AttributeError when starting VM with floppy attached on statistics sampling
Product: [Retired] oVirt Reporter: Haim <hateya>
Component: vdsmAssignee: Igor Lvovsky <ilvovsky>
Status: CLOSED CURRENTRELEASE QA Contact: Haim <hateya>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: abaron, acathrow, bazulay, hateya, iheim, ilvovsky, lpeer, mgoldboi, ohochman, yeylon, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: virt
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-05-09 12:48:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Haim 2012-02-16 15:23:59 UTC 
Description of problem:

- start new vm with floppy attached
- query logs 

read-221::ERROR::2012-02-16 17:12:43,462::utils::399::vm.Vm::(collect) vmId=`2aed27de-bc3f-40cb-85b3-1839f8e38279`::Stats function failed: <AdvancedStatsFunction _sampleDiskL
atency at 0x207a7a0>
Traceback (most recent call last):
  File "/usr/share/vdsm/utils.py", line 395, in collect
    statsFunction()
  File "/usr/share/vdsm/utils.py", line 272, in __call__
    retValue = self._function(*args, **kwargs)
  File "/usr/share/vdsm/libvirtvm.py", line 158, in _sampleDiskLatency
    diskLatency[vmDrive.name] = stats[vmDrive.alias]
AttributeError: 'Drive' object has no attribute 'alias'


Inside the code, vdsm catch the exception from type KeyError, but not AttributeError.  

 156         for vmDrive in self._vm._devices[vm.DISK_DEVICES]:                                                                                                                 
 157             try:                                                                                                                                                           
 158                 diskLatency[vmDrive.name] = stats[vmDrive.alias]                                                                                                           
 159             except KeyError, AttributeError:                                                                                                                               
 160                 diskLatency[vmDrive.name] = {'rd_op':0, 'wr_op':0, 'flush_op':0,                                                                                           
 161                                              'rd_total_time_ns':0,                                                                                                         
 162                                              'wr_total_time_ns':0,                                                                                                         
 163                                              'flush_total_time_ns':0}                                                                                                      
 164                 self._log.warn("Disk %s latency not available", vmDrive.name) 

last commit in git: b183748699b00fc1396059e946d5772eaa471e26
Comment 1 Haim 2012-05-08 14:49:19 UTC 
need to check on downstream.
Comment 2 Omri Hochman 2012-05-09 08:52:30 UTC 
(In reply to comment #1)
> need to check on downstream.

Not reproducible 3.1 downstream 
build (si3), vdsm-4.9.6-8.