Bug 795069 - Review Request: sugar-countries - Countries is a game to play with identifying countries
Summary: Review Request: sugar-countries - Countries is a game to play with identifyin...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Jan-Frode Myklebust
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-19 04:33 UTC by Kalpa Welivitigoda
Modified: 2012-03-24 00:32 UTC (History)
4 users (show)

Fixed In Version: sugar-countries-33-2.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-16 21:20:52 UTC
Type: ---
Embargoed:
janfrode: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Kalpa Welivitigoda 2012-02-19 04:33:37 UTC
Spec URL: http://callkalpa.fedorapeople.org/sugar-countries/sugar-countries.spec
SRPM URL: http://callkalpa.fedorapeople.org/sugar-countries/sugar-countries-33-1.fc16.src.rpm

Description:

I have packaged sugar-countries which is a game where players have to type in a country for each letter of the alphabet. Successes are rewarded with the display of the country's flag. The activity consists of the English names of 212 countries.

Comment 1 Jan-Frode Myklebust 2012-03-10 14:16:48 UTC
The spec file lists URL: http://mulawa.net/olpc/countries which doesn't seem to tell much about this application. Isn't there a proper homepage for it ?

Nitpick: you're doing "chmod +x setup.py" and later "%{__python} ./setup.py".. so I don't think the chmod should be needed.

Could you please show output of rpmlint on fedora 16?

Comment 2 Kalpa Welivitigoda 2012-03-10 14:50:53 UTC
fixed the issues and here are the new files

Spec URL:
http://callkalpa.fedorapeople.org/sugar-countries/sugar-countries.spec
SRPM URL:
http://callkalpa.fedorapeople.org/sugar-countries/sugar-countries-33-2.fc16.src.rpm

rpmlint on spec and srpm on fedora 16
rpmlint sugar-countries.spec ../SRPMS/sugar-countries-33-2.fc16.src.rpm 
sugar-countries.spec:6: W: non-standard-group Sugar/Activities
sugar-countries.src: W: non-standard-group Sugar/Activities
1 packages and 1 specfiles checked; 0 errors, 2 warnings.

Comment 3 Jan-Frode Myklebust 2012-03-10 15:12:59 UTC
This updated srpm seems corrupted, or incompatible with RHEL6 (v33-1 works):

   unpacking of archive failed on file /home/janfrode/rpmbuild/SOURCES/countries-33.xo;4f5b6edc: cpio: read 

But the updated specfile seems OK.
 
It was the non-standard-group I was wondering if rpmlint would complain about on f16 too. I see the is used in the sugar-packaging guidelines, so I assume it should be OK.

Comment 4 Kalpa Welivitigoda 2012-03-10 15:24:12 UTC
Sorry I have cancelled it half way uploading to fedorapeople. Here is the new file

SRPM URL:
http://callkalpa.fedorapeople.org/sugar-countries/sugar-countries-33-2.fc16.src.rpm

non-standard-group warning is there with sugar activities and it is ignored for them.

Comment 5 Kalpa Welivitigoda 2012-03-10 15:50:34 UTC
New Package SCM Request
=======================
Package Name: sugar-countries
Short Description: a sugar activity to play with identifying countries
Owners: callkalpa
Branches: f15 f16 f17
InitialCC: pbrobinson

Comment 6 Gwyn Ciesla 2012-03-12 12:12:17 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2012-03-12 17:17:52 UTC
sugar-countries-33-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/sugar-countries-33-2.fc15

Comment 8 Fedora Update System 2012-03-12 17:18:01 UTC
sugar-countries-33-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/sugar-countries-33-2.fc16

Comment 9 Fedora Update System 2012-03-12 17:18:31 UTC
sugar-countries-33-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/sugar-countries-33-2.fc17

Comment 10 Fedora Update System 2012-03-12 19:09:08 UTC
sugar-countries-33-2.fc17 has been pushed to the Fedora 17 testing repository.

Comment 11 Fedora Update System 2012-03-16 21:20:52 UTC
sugar-countries-33-2.fc17 has been pushed to the Fedora 17 stable repository.

Comment 12 Fedora Update System 2012-03-24 00:27:32 UTC
sugar-countries-33-2.fc16 has been pushed to the Fedora 16 stable repository.

Comment 13 Fedora Update System 2012-03-24 00:32:55 UTC
sugar-countries-33-2.fc15 has been pushed to the Fedora 15 stable repository.


Note You need to log in before you can comment on or make changes to this bug.