Bug 796850 - lldpad: DCBX: segfault may occur when clearing advertise bit
Summary: lldpad: DCBX: segfault may occur when clearing advertise bit
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: lldpad
Version: 6.3
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Petr Šabata
QA Contact: qe-baseos-daemons
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-23 18:49 UTC by john.r.fastabend
Modified: 2012-06-20 14:14 UTC (History)
7 users (show)

Fixed In Version: lldpad-0.9.43-14.el6
Doc Type: Bug Fix
Doc Text:
No documentation needed.
Clone Of:
Environment:
Last Closed: 2012-06-20 14:14:54 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2012:0901 0 normal SHIPPED_LIVE lldpad bug fix and enhancement update 2012-06-19 20:47:01 UTC

Description john.r.fastabend 2012-02-23 18:49:37 UTC
If the user clears the advertise bit on the APP TLV a segfault may occur due to a bad memcpy. Fix below is available @,

http://www.open-lldp.org/git/?p=lldp/open-lldp.git;a=commit;h=f5ec9455763ad646ed6fa41f5ea2d8f8ccb0c61b

---

author     John Fastabend <john.r.fastabend>
           Wed, 1 Feb 2012 19:11:03 -0800 (19:11 -0800)
committer  John Fastabend <john.r.fastabend>
           Wed, 1 Feb 2012 19:11:03 -0800 (19:11 -0800)
commit     f5ec9455763ad646ed6fa41f5ea2d8f8ccb0c61b

lldpad: DCBX: bad memcpy with APP !advertised

The bld app routines do not verify the application TLV is actually
being advertised before trying to do a memcpy. This can result in
a bad memcpy.

Signed-off-by: John Fastabend <john.r.fastabend>
Tested-by: Ross Brattain <ross.b.brattain>

Comment 3 Robert Love 2012-02-24 23:41:39 UTC
Intel observed this defect in RHEL6.2. We're a bit unclear as to whether this meets the 6.2 errata critera to get this patch backported. It's certainly a bad problem (segfault), but it's user space. At this point I just wanted to make RH aware that the failure exists in RHEL6.2.

Comment 5 Petr Šabata 2012-02-29 14:40:20 UTC
Pushed as lldpad-0.9.43-14.el6.

Comment 8 kavindya.s.deegala 2012-04-04 23:53:23 UTC
Verification failed with Red Hat 6.3 Alpha

Comment 9 kavindya.s.deegala 2012-04-10 22:13:40 UTC
Please ignore Comment 8. 

Verification passed with Red hat 6.3 Alpha.

Comment 10 Stephen Wadeley 2012-06-08 14:04:17 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No documentation needed.

Comment 11 errata-xmlrpc 2012-06-20 14:14:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0901.html


Note You need to log in before you can comment on or make changes to this bug.