Bug 797141 - fedora-create-review fails with 'list index out of range' if you give a bare filename without a path
Summary: fedora-create-review fails with 'list index out of range' if you give a bare ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-review
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Stanislav Ochotnicky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-24 11:27 UTC by Mary Ellen Foster
Modified: 2012-02-24 11:34 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-24 11:34:27 UTC
Type: ---

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Mary Ellen Foster 2012-02-24 11:27:41 UTC 
Description of problem:
If you use 'fedora-create-review' when you're in the directory containing either the spec or the srpm, and you give just a bare filename with no path, fedora-create-review will die after uploading the files with 'list index out of range'.

This seems to be because of lines 236-237, which look for a "/" character in the filenames of the spec and srpm files to get the base name.

Version-Release number of selected component (if applicable):
fedora-review-0.1.2-1.fc16.noarch

How reproducible:
Every time

Steps to Reproduce:
1. (from the SRMPS directory) fedora-create-review ../SPECS/eclipse-color-theme.spec eclipse-color-theme-0.11.1-1.fc16.src.rpm
  
Actual results:
Starting scratch build
Uploading files into fedorapeople
list index out of range

Expected results:
Creating the review request

Additional info:
The above works if I use "./eclipse-color-theme-0.11.1-1.fc16.src.rpm" -- that is, if there's at least one slash in both paths.
Comment 1 Pierre-YvesChibon 2012-02-24 11:34:27 UTC 
Thanks for reporting this.

It has been fixed upstream already in: http://git.fedorahosted.org/git/?p=FedoraReview.git;a=commit;h=76fc9ae4d7265cb60efebe0f1d0b60d7edf85d1e
Note You need to log in before you can comment on or make changes to this bug.