Bug 797901 - Ruby 1.9.3 compatibility
Summary: Ruby 1.9.3 compatibility
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gdal
Version: 17
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Devrim Gündüz
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-27 13:39 UTC by Vít Ondruch
Modified: 2012-03-21 19:05 UTC (History)
11 users (show)

Fixed In Version: gdal-1.9.0-2.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-21 19:05:26 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Vít Ondruch 2012-02-27 13:39:26 UTC
I have noticed that you have tried to update the package to be compatible with new Ruby package, however, it is not perfect yet:

1) Line 133: you are referencing quite old wiki page, which is not relewant to updated ruby. The most relevant is new packaging line draf [1], unfortunately it is WIP ATM.

2) Line 134: We do not place ruby libraries into "ruby_sitearch" but instead, we are using "ruby_vendorarch". Please note that these macros are newly provided by ruby-devel package, so you don't have to fetch them from Ruby. You can find inspiration in ruby-RMagick [2] package for example.

3) Line 186: The ruby package provides "ruby(abi) = 1.9.1" and the same should be required by guidelines.




[1] https://fedoraproject.org/wiki/PackagingDrafts/Ruby
[2] http://pkgs.fedoraproject.org/gitweb/?p=ruby-RMagick.git;a=blob;f=ruby-RMagick.spec;h=182754cda7d09f01917be9ab943cee1d3d228e77;hb=HEAD

Comment 1 Volker Fröhlich 2012-02-27 14:22:14 UTC
Thanks for looking at it. I'll take care of it as soon as I find the time.

Comment 2 Vít Ondruch 2012-02-27 14:36:30 UTC
Thank you. I appreciate that.

Comment 3 Orion Poplawski 2012-03-09 23:32:11 UTC
On a somewhat related note:

sed -i -e "s/\$(CFLAGS)/$(CFLAGS) -fPIC/g" swig/ruby/RubyMakefile.mk

results in:

++ CFLAGS
/var/tmp/rpm-tmp.a2zKDr: line 99: CFLAGS: command not found
+ sed -i -e 's/$(CFLAGS)/ -fPIC/g' swig/ruby/RubyMakefile.mk

Because $(CFLAGS) passes "CFLAGS" to the shell and replaces it with the output of that command.  You probably want:

sed -i -e 's/$(CFLAGS)/$(CFLAGS) -fPIC/g' swig/ruby/RubyMakefile.mk

Comment 4 Volker Fröhlich 2012-03-13 07:26:05 UTC
Thank you, both issues should be solved with 1.9.0-2.

Vít, is ruby_vendorarch something upstreams should use in the first place now (for Ruby 1.9 and up)?

Comment 5 Fedora Update System 2012-03-13 16:11:47 UTC
gdal-1.9.0-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gdal-1.9.0-2.fc17

Comment 6 Bohuslav "Slavek" Kabrda 2012-03-14 06:42:47 UTC
(In reply to comment #4)
> Thank you, both issues should be solved with 1.9.0-2.
> 
> Vít, is ruby_vendorarch something upstreams should use in the first place now
> (for Ruby 1.9 and up)?

Hi Volker,
it was basically Vit's work to push the vendor dirs to ruby upstream and we would certainly love everyone to use them. Another thing is that other distributions probably don't even know about these, so I'm not sure if we can make the upstreams do that (but yes, ideally, they should).

Comment 7 Fedora Update System 2012-03-16 02:40:25 UTC
Package gdal-1.9.0-2.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gdal-1.9.0-2.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-3793/gdal-1.9.0-2.fc17
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2012-03-21 19:05:26 UTC
gdal-1.9.0-2.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.