Bug 797957 - TimeoutBase.getLegal() logic issue
Summary: TimeoutBase.getLegal() logic issue
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: unspecified
Hardware: All
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Laszlo Hornyak
QA Contact:
URL:
Whiteboard: infra
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-27 15:57 UTC by Laszlo Hornyak
Modified: 2013-11-13 15:46 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-13 08:12:37 UTC
oVirt Team: ---

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Laszlo Hornyak 2012-02-27 15:57:34 UTC 
Description of problem:

Two possible problems with TimeOutBase.getLegal():

 - synchronizes agains a global lock Object, but reads from a HashMap that is not synchronized
 - if there is a timeoutBase which has its timeout over, then the timeout will be just removed but no new timeout set, so this auditloggable could be logged twice in the period set
Comment 1 Itamar Heim 2012-12-13 08:12:37 UTC 
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.
Note You need to log in before you can comment on or make changes to this bug.