Bug 801415 - Remove jPDL migration tool from productized designer
Summary: Remove jPDL migration tool from productized designer
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise BRMS Platform 5
Classification: JBoss
Component: jBPM 5
Version: BRMS 5.3.0.GA
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ER7
: BRMS 5.3.0.GA
Assignee: lcarlon
QA Contact: Petr Široký
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-03-08 13:37 UTC by Jiri Locker
Modified: 2013-04-30 03:22 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-25 02:54:15 UTC
Type: Bug


Attachments (Terms of Use)
jPDL_migration_button (156.14 KB, image/png)
2012-05-09 09:25 UTC, Ryan Zhang
no flags Details

Description Jiri Locker 2012-03-08 13:37:45 UTC
Description of problem:
jPDL migration is not a requirement for this release and so the feature should be excluded from the product.

Version-Release number of selected component (if applicable):
BRMS 5.3.0 ER4

Actual results:
the button titled "Migrate jPDL 3.2 to BPMN2" is present

Expected results:
the button should be removed

Additional info:

Comment 1 Tihomir Surdilovic 2012-03-08 15:20:19 UTC
Could we keep it and document its experimental/not-supported feature? There are plenty of other tools such as jbpm plugin in JBDS were we document what nodes for example in the stencil set are considered supported and which are not. Why have to remove it completely?

Comment 2 Lukáš Petrovický 2012-03-08 15:37:31 UTC
(In reply to comment #1)
> Could we keep it and document its experimental/not-supported feature? There are
> plenty of other tools such as jbpm plugin in JBDS were we document what nodes
> for example in the stencil set are considered supported and which are not. Why
> have to remove it completely?

I think that's up to Prakash to decide.

Comment 3 Tihomir Surdilovic 2012-03-08 15:41:46 UTC
Ok, how do we ask him to decide sooner than later, because this would require  some work to make it enabled in community and not for product.

Comment 4 Prakash Aradhya 2012-03-08 15:49:45 UTC
Tiho, I see your point.  This migration support is a hot topic.  It is a tough call we need to make to avoid too much burden on GSS.  We rather encourage people to opt-in by including documentation on how to enable that plugin.
By default enabling it opens up lot of questions.

So, lets disable it by default.  In the docs we can show steps on how to enable to and clearly state that it is a preview in this release and not fully supported.

Comment 5 Tihomir Surdilovic 2012-03-08 15:56:19 UTC
Ok, I'll work on this next week and externalize it into its own plugin and allow user-configuration to add it. In community this will be "on" by default so product build will have to disable a line of xml in jbpm.xml (which they already later for the differences in URLs between drools-guvnor and jboss-brms). Hope this is OK solution for everyone.

Comment 6 Lukáš Petrovický 2012-03-08 16:09:18 UTC
(In reply to comment #5)
> Ok, I'll work on this next week and externalize it into its own plugin and
> allow user-configuration to add it. In community this will be "on" by default
> so product build will have to disable a line of xml in jbpm.xml (which they
> already later for the differences in URLs between drools-guvnor and
> jboss-brms). Hope this is OK solution for everyone.

Sounds good.

Comment 7 Prakash Aradhya 2012-03-08 16:10:46 UTC
Ok.. lets make sure Ryan (productization) team picks it up well in advance, so that it starts appearing in the early builds.
Please ping Ryan when you have it done.

Comment 8 Tihomir Surdilovic 2012-03-28 14:10:33 UTC
jpdl migration feature has been externalized to its own plugin. for the product to remove it please make sure that the:

<plugin name="ORYX.Plugins.JPDLMigration"/>

definition in $designer_war/profiles/jbpm.xml is commented. i have left it uncommented for the community

this fix is checked into designer master and 2.1.x branch.

Comment 9 Ryan Zhang 2012-04-23 07:38:39 UTC
Update status to ON_QA. Please verify them against ER6.

Comment 11 Jiri Locker 2012-05-04 15:36:32 UTC
jPDL migration plugin can be disabled in ER6 but designer comes with this plugin enabled. The plugin element

> <plugin name="ORYX.Plugins.JPDLMigration"/>

must be commented out, which needs to be covered in the build process. Assigning to Ryan.

Comment 12 Ryan Zhang 2012-05-09 09:24:24 UTC
This is done for next release.
svn ci -m "BZ 801415 disable jPDL migration tool"
Sending        src/main/patches/processdesigner/patch_designer_conf.xml
Transmitting file data .
Committed revision 11008.

Re-assign to Lee for documentation updates.
Lee, this might need to add some guide in documentations for how to enable function "Migrate jPDL 3.2 to BPMN2" as Prakash mentioned in comments 4.

The steps to enable it is change the line in brms-standalone-5.3.0/jboss-as/server/${conf}/deploy/designer.war/profiles/jbpm.xml
from
<!--plugin name="ORYX.Plugins.JPDLMigration"/-->
to 
<plugin name="ORYX.Plugins.JPDLMigration"/>

And restart the server, the function/button should be able to appear in the toolbar and be enabled used.

I attached a screen shot for your reference.
By default, the button is not present.

Comment 13 Ryan Zhang 2012-05-09 09:25:26 UTC
Created attachment 583202 [details]
jPDL_migration_button

Comment 15 Ryan Zhang 2012-05-14 08:15:50 UTC
The fixed for this issue should be included in ER7. Please do verification on it.

Comment 16 Petr Široký 2012-05-21 17:09:47 UTC
Verified fixed in 5.3.0 ER7. JPDL migration is disabled by default. Doc-stage is down right now, so I will verify the documentation when its up and then set the status to verified.

Comment 17 lcarlon 2012-06-25 02:54:15 UTC
Closing as status already set to verified.


Note You need to log in before you can comment on or make changes to this bug.