Bug 801468 - Improve UserPortalListModel to comply with standard Window/ConfirmWindow property handling
Summary: Improve UserPortalListModel to comply with standard Window/ConfirmWindow prop...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-userportal
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.1
Assignee: Einav Cohen
QA Contact:
URL:
Whiteboard: ux
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-03-08 15:48 UTC by Vojtech Szocs
Modified: 2012-08-09 07:58 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-09 07:58:52 UTC
oVirt Team: ---

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Vojtech Szocs 2012-03-08 15:48:58 UTC 
In uicommonweb project, UserPortalListModel is the list model responsible for managing VM and Pool data in UserPortal.

However, unlike other models that use Window/ConfirmWindow properties for storing dialog models, UserPortalListModel uses its own custom properties for this purpose.

UserPortalListModel custom properties that correspond to Window:
- "VmModel" property for storing UnitVmModel (New Server, New Desktop, Edit and Make Template dialogs)
- "RunOnceModel" property for storing RunOnceModel (Run Once dialog)
- "AttachCdModel" property for storing AttachCdModel (Change CD dialog)

UserPortalListModel custom properties that correspond to ConfirmWindow
- "ConfirmationModel" property for storing ConfirmationModel

This makes it harder for UserPortal to handle these non-standard dialog properties. Custom properties mentioned above should be replaced with standard setWindow() / setConfirmWindow() calls.
Comment 1 Vojtech Szocs 2012-05-17 08:50:23 UTC 
Patch merged upstream, git commit cc68513979cc646d9005dfae78621e1f790353fb, Gerrit reference [http://gerrit.ovirt.org/4391].
Comment 2 Itamar Heim 2012-08-09 07:58:52 UTC 
closing ON_QA bugs as oVirt 3.1 was released:
http://www.ovirt.org/get-ovirt/
Note You need to log in before you can comment on or make changes to this bug.