Spec URL: http://bkabrda.fedorapeople.org/pkgs/http-parser/python-http-parser.spec SRPM URL: http://bkabrda.fedorapeople.org/pkgs/http-parser/python-http-parser-0.7.5-1.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3895969 Description: HTTP request/response parser for Python compatible with Python 2.x (>=2.5.4), Python 3 and Pypy. If possible a C parser based on http-parser_ from Ryan Dahl will be used.
Taking this one
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. [x]: MUST Package is not relocatable. [!]: MUST Development (unversioned) .so files in -devel subpackage, if present. Note: python-http-parser-0.7.5-1.fc18.i686.rpm : /usr/lib/python2.7/site- packages/http_parser/parser.so false positive ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [!]: MUST Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib/python2.7/site- packages/http_parser [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint python-http-parser-0.7.5-1.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint python-http-parser-0.7.5-1.fc18.i686.rpm python-http-parser.i686: W: private-shared-object-provides /usr/lib/python2.7/site-packages/http_parser/parser.so parser.so python-http-parser.i686: E: non-standard-executable-perm /usr/lib/python2.7/site-packages/http_parser/parser.so 0775L 1 packages and 0 specfiles checked; 1 errors, 1 warnings. rpmlint python-http-parser-debuginfo-0.7.5-1.fc18.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/mrunge/review/803601/http-parser-0.7.5.tar.gz : MD5SUM this package : 0a1092f4920f2e77d86aa3602281d4a0 MD5SUM upstream package : 0a1092f4920f2e77d86aa3602281d4a0 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [-]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages [!]: MUST Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib/python2.7/site- packages/http_parser See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 See: None [!]: MUST Rpmlint output is silent. rpmlint python-http-parser-0.7.5-1.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint python-http-parser-0.7.5-1.fc18.i686.rpm python-http-parser.i686: W: private-shared-object-provides /usr/lib/python2.7/site-packages/http_parser/parser.so parser.so python-http-parser.i686: E: non-standard-executable-perm /usr/lib/python2.7/site-packages/http_parser/parser.so 0775L 1 packages and 0 specfiles checked; 1 errors, 1 warnings. rpmlint python-http-parser-debuginfo-0.7.5-1.fc18.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint You should correct the error on non standard exec. perm. If you're not supporting EL5, you should remove rm -rf %{buildroot} from build section. You should use something like the following at files-section: %{python_sitelib}/http_parser %{python_sitearch}/http_parser %{python_sitearch}/http_parser-%{version}-py?.?.egg-info
> You should correct the error on non standard exec. perm. Ah, this is actually a matter of filtering the provide [1] of the .so file. Done. If you're not > supporting EL5, you should remove rm -rf %{buildroot} from build section. > Yep, forgot about that. Done. > > You should use something like the following at files-section: > %{python_sitelib}/http_parser > %{python_sitearch}/http_parser > %{python_sitearch}/http_parser-%{version}-py?.?.egg-info Actually, the problem here was, that the files in "data_files" in setup.py were placed under sitelib, not under sitearch. Therefore, on 32 bit architecture, where these two are the same, the files were listed twice. The data files should usually be placed alongside the others, but the upstream does a lot of tinkering with the setup, so I just specified the location explicitly. And everything should be ok now. Here is the updated stuff: SPEC: http://bkabrda.fedorapeople.org/pkgs/http-parser/python-http-parser.spec SRPM: http://bkabrda.fedorapeople.org/pkgs/http-parser/python-http-parser-0.7.5-2.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3897103 [1] https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering
Yeah, I saw this interesting file placement earlier, too. It is now fixed. OK I don't see any further issues, so APPROVED!
Thank you for your review! New Package SCM Request ======================= Package Name: python-http-parser Short Description: HTTP request/response parser for Python Owners: bkabrda Branches: f17 InitialCC:
Git done (by process-git-requests).
python-http-parser-0.7.5-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-http-parser-0.7.5-2.fc17
python-http-parser-0.7.5-2.fc17 has been pushed to the Fedora 17 testing repository.
python-http-parser-0.7.5-2.fc17 has been pushed to the Fedora 17 stable repository.