swt-chart is a charting framework for SWT (Standard Widget Toolkit). It is light-weight (depending on just SWT), and is very easy to implement. SPEC : http://rgrunber.fedorapeople.org/eclipse-swtchart/swt-chart.spec SRPM : http://rgrunber.fedorapeople.org/eclipse-swtchart/swt-chart-0.8.0-1.fc18.src.rpm Scratch Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3901685
I'll take this one.
Links were wrong. I have reviewed http://rgrunber.fedorapeople.org/swt-chart/sqwt-chart.spec and http://rgrunber.fedorapeople.org/swt-chart/swt-chart-0.8.0-1.fc18.src.rpm Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Rpmlint output: swt-chart.spec: W: invalid-url Source0: swt-chart-0.8.0.tar.xz [x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [?] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : MD5SUM upstream package: Not evaluated as sources are fetched from repo by a script [!] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates or must require other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] File sections do not contain %defattr(-,root,root,-) unless changed with good reason [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [x] Fully versioned dependency in subpackages, if present. [x] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Javadoc documentation files are generated and included in -javadoc subpackage [x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [!] Javadoc subpackages have Require: jpackage-utils [x] Package uses %global not %define [x] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [x] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [x] If package contains pom.xml files install it (including depmaps) even when building with ant [x] pom files has correct add_maven_depmap === Maven === [x] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [x] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [x] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment [x] Package DOES NOT use %update_maven_depmap in %post/%postun [x] Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro === Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [x] Latest version is packaged. [?] Reviewer should test that the package builds in mock. Tested on: tycho 0.14 is not mirrored yet. === Issues === 1. BuildRequires and Requires should specify respectively java-devel and java >= 1.5 as this is what is present in MANIFEST.MF 2. Javadoc subpackage does not have Require: jpackage-utils 3. Should not be the jar symlinked to eclipse dropins? [1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines [2] https://fedoraproject.org/wiki/Packaging:Guidelines [3] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines [4] https://fedoraproject.org/wiki/Licensing:Main [5] https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 [6] https://fedoraproject.org/wiki/Packaging:Java#Filenames
The jar should not be symlinked in eclipse dropins as it's perfectly usable outside of eclipse. Any plugin that makes use of it will have to use it via the pdebuild -o option. This confusion comes from missing system wide bundle repository which will stay for the future.
Hey, thanks for the review :) I've fixed (1), and (2). The Requires: jpackage-utils on -javadoc was there, but hard to see due to being directly under Summary/Group so I've spaced it out. SPEC : http://rgrunber.fedorapeople.org/swt-chart/swt-chart.spec-2 SRPM : http://rgrunber.fedorapeople.org/swt-chart/swt-chart-0.8.0-2.fc18.src.rpm
================ *** APPROVED *** ================
Thanks Again! New Package SCM Request ======================= Package Name: swt-chart Short Description: A lightweight charting framework for SWT. Owners: rgrunber Branches: f17 InitialCC:
Git done (by process-git-requests).
swt-chart has built successfully in rawhide and f17. Closing as NEXTRELASE.