Bug 804737 - rpmdiff: Improper patch call in specfile
Summary: rpmdiff: Improper patch call in specfile
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: CloudForms Common
Classification: Retired
Component: rubygem-sqlite3
Version: 1.0.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: beta2
Assignee: John Eckersberg
QA Contact: Og Maciel
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-03-19 17:23 UTC by Jay Turner
Modified: 2015-01-08 00:17 UTC (History)
9 users (show)

Fixed In Version: rubygem-sqlite3-1.3.3-8.el6cf
Doc Type: Bug Fix
Doc Text:
rubygem-sqlite3 contained a non-standard packaging format for a patch. This bug fix corrects the packaging format.
Clone Of:
Environment:
Last Closed: 2012-12-04 14:59:26 UTC


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2012:1516 0 normal SHIPPED_LIVE CloudForms Cloud Engine 1.1 update 2012-12-04 19:51:45 UTC

Description Jay Turner 2012-03-19 17:23:41 UTC
Description of problem:
Specfile includes:

'patch -l -p0 < %{PATCH0}' which is not standard Red Hat packaging format.

Should simply be:
%patch0 (salt to taste).

Version-Release number of selected component (if applicable):
1.3.3-6.el6

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jordan OMara 2012-03-22 21:32:53 UTC
closing, WONTFIX, removing from ce/se/sam tag

Comment 2 Jay Turner 2012-04-27 14:46:31 UTC
I'm back!  rubygem-sqlite3 got pulled back into the mix late in the game so this package is indeed shipping again.  Instead of just fixing it the first time around so the packaging would be correct for anyone else that picked up the package, the lazy road was taken and now we're forced to ship non-compliant packaging in a GA product.  Flagging against 1.0.z.  QE ack to blocker for 1.0.z.

Comment 6 John Eckersberg 2012-09-07 21:33:57 UTC
Note to self so I don't forget this over the weekend...

The offending patch command is happening in the %check section, but the %patch macro only works in the %prep section.  Because of this, in the %prep section, we'll need to:

- unpack %{SOURCE0}
- patch it with the %patch macro

And then in the %build section instead of just gem installing %{SOURCE0}...

- rebuild the .gem from the unpacked, patched source
- gem install the resultant .gem file.

Something like: http://fedoraproject.org/wiki/Packaging:Ruby#Building_gems

Comment 8 Chandrasekar Kannan 2012-11-06 17:31:37 UTC
tested with rubygem-sqlite3-1.3.3-9.el6cf.src.rpm

verified.

.live.[root@qe-blade-01 SPECS]# grep -i patch0 rubygem-sqlite3.spec 
Patch0:         %{name}-1.3.3-big-endian.patch
%patch0

Comment 10 errata-xmlrpc 2012-12-04 14:59:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2012-1516.html


Note You need to log in before you can comment on or make changes to this bug.