RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 806386 - Uninitialized return value in 'sudo' package.
Summary: Uninitialized return value in 'sudo' package.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: sudo
Version: 6.3
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Daniel Kopeček
QA Contact: BaseOS QE Security Team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-03-23 15:35 UTC by Pavel Raiskup
Modified: 2012-11-06 10:59 UTC (History)
3 users (show)

Fixed In Version: sudo-1.7.4p5-9.el6
Doc Type: Bug Fix
Doc Text:
No documentation needed.
Clone Of:
Environment:
Last Closed: 2012-06-20 14:22:08 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2012:0905 0 normal SHIPPED_LIVE sudo bug fix update 2012-06-19 20:46:54 UTC

Description Pavel Raiskup 2012-03-23 15:35:57 UTC
New Coverity scan has found one new potential defect in 'sudo.1.7.4p5-8'
against 'sudo-1.7.4p5-7.el6':

Returning of uninitialized variable 'j' on sudo_edit.c:343.

It seems there was a try to initialize this variable in the source, but on a
bad position -- proposed fix could look like this:

| --- a/sudo_edit.c
| +++ b/sudo_edit.c
| @@ -335,9 +335,9 @@
|                     warningx("contents of edit session left in %s", tf[i].tfile);
|                }
|                close(ofd);
| -
| -              j = 0;
|           }
| +
| +         j = 0;
|       }
|
|       return j;

.. or maybe better approach, initialize it on the top of the function.  This
potential problem was added by sudo-1.7.4p5-sudoedit-selinux.patch.

This error is mentioned just as a warning and it depends on you whether it will
be fixed or not.  Feel free to move this bug to 6.4 if you think it is not
necessary to fix it in 6.3 or close it as a NOTABUG if we don't need to fix
it at all.

We are able to re-run Coverity for verifying potential fixes.

Comment 2 Daniel Kopeček 2012-03-23 15:42:04 UTC
Thanks for the report. This needs to be fixed.

Comment 7 Daniel Kopeček 2012-05-29 09:23:31 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No documentation needed.

Comment 8 errata-xmlrpc 2012-06-20 14:22:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0905.html

Comment 9 Dalibor Pospíšil 2012-11-06 10:59:14 UTC
Setting qe_test_coverage‑. This is covered by Coverity scan.


Note You need to log in before you can comment on or make changes to this bug.