Red Hat Bugzilla – Bug 806386
Uninitialized return value in 'sudo' package.
Last modified: 2012-11-06 05:59:14 EST
New Coverity scan has found one new potential defect in 'sudo.1.7.4p5-8'
Returning of uninitialized variable 'j' on sudo_edit.c:343.
It seems there was a try to initialize this variable in the source, but on a
bad position -- proposed fix could look like this:
| --- a/sudo_edit.c
| +++ b/sudo_edit.c
| @@ -335,9 +335,9 @@
| warningx("contents of edit session left in %s", tf[i].tfile);
| - j = 0;
| + j = 0;
| return j;
.. or maybe better approach, initialize it on the top of the function. This
potential problem was added by sudo-1.7.4p5-sudoedit-selinux.patch.
This error is mentioned just as a warning and it depends on you whether it will
be fixed or not. Feel free to move this bug to 6.4 if you think it is not
necessary to fix it in 6.3 or close it as a NOTABUG if we don't need to fix
it at all.
We are able to re-run Coverity for verifying potential fixes.
Thanks for the report. This needs to be fixed.
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
No documentation needed.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
Setting qe_test_coverage‑. This is covered by Coverity scan.