Bug 806542 - Review Request: php-channel-phpdoc - Adds phpdoc channel to PEAR
Summary: Review Request: php-channel-phpdoc - Adds phpdoc channel to PEAR
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-03-24 15:24 UTC by Christof Damian
Modified: 2012-06-03 23:26 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-03 23:26:00 UTC
Type: ---
fedora: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
review.txt (6.46 KB, text/plain)
2012-05-21 18:19 UTC, Remi Collet 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Description Christof Damian 2012-03-24 15:24:51 UTC 
Spec URL: http://rpms.damian.net/SPECS/php-channel-phpdoc.spec
SRPM URL: http://rpms.damian.net/SRPMS/php-channel-phpdoc-1.3-1.fc16.src.rpm
Description: This package adds the phpdoc channel which allows PEAR packages from this channel to be installed.
Comment 1 Remi Collet 2012-05-21 14:18:56 UTC 
Please 
- remove php-cli from requires
- change license to Public Domain
- clean unneeded macros (rm, install, mkdir)
Comment 2 Christof Damian 2012-05-21 18:07:25 UTC 
(In reply to comment #1)
> Please 
> - remove php-cli from requires
> - change license to Public Domain
> - clean unneeded macros (rm, install, mkdir)

Spec URL: http://rpms.damian.net/SPECS/php-channel-phpdoc.spec
SRPM URL: http://rpms.damian.net/SRPMS/php-channel-phpdoc-1.3-2.fc16.src.rpm

new version with fixes.
Comment 3 Remi Collet 2012-05-21 18:19:26 UTC 
Created attachment 585871 [details]
review.txt

Report from fedora-review 0.1.3
Comment 4 Remi Collet 2012-05-21 18:20:58 UTC 
[!]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/extras/SPECS/review/806542/channel.xml :
  MD5SUM this package     : 9a98bf7cb7f1283d66d72b67a60db274
  MD5SUM upstream package : 0b849ebcb14fcb60f70b0fa66f4c65fa

Please fix the channel.xml (you provide the one from pear.phpqatools.org)
Comment 5 Christof Damian 2012-05-21 18:55:20 UTC 
(In reply to comment #4)
> [!]: MUST Sources used to build the package match the upstream source, as
>      provided in the spec URL.
> /home/extras/SPECS/review/806542/channel.xml :
>   MD5SUM this package     : 9a98bf7cb7f1283d66d72b67a60db274
>   MD5SUM upstream package : 0b849ebcb14fcb60f70b0fa66f4c65fa
> 
> Please fix the channel.xml (you provide the one from pear.phpqatools.org)

Sorry, no idea how that happened. I thought I checked it. Here is a new one:

Spec URL: http://rpms.damian.net/SPECS/php-channel-phpdoc.spec
SRPM URL: http://rpms.damian.net/SRPMS/php-channel-phpdoc-1.3-3.fc16.src.rpm
Comment 6 Remi Collet 2012-05-22 05:43:08 UTC 
  MD5SUM this package     : 0b849ebcb14fcb60f70b0fa66f4c65fa
  MD5SUM this package     : 0b849ebcb14fcb60f70b0fa66f4c65fa


APPROVED
Comment 7 Christof Damian 2012-05-23 21:28:58 UTC 
(In reply to comment #6)
>   MD5SUM this package     : 0b849ebcb14fcb60f70b0fa66f4c65fa
>   MD5SUM this package     : 0b849ebcb14fcb60f70b0fa66f4c65fa
> 
> 
> APPROVED

cheers

New Package SCM Request
=======================
Package Name: php-channel-phpdoc
Short Description: Adds phpdoc channel to PEAR
Owners: cdamian
Branches: f17 f16 el6
InitialCC:
Comment 8 Gwyn Ciesla 2012-05-24 14:34:23 UTC 
Git done (by process-git-requests).
Comment 9 Fedora Update System 2012-05-24 19:24:23 UTC 
php-channel-phpdoc-1.3-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/php-channel-phpdoc-1.3-3.fc17
Comment 10 Fedora Update System 2012-05-26 06:48:20 UTC 
php-channel-phpdoc-1.3-3.fc17 has been pushed to the Fedora 17 testing repository.
Comment 11 Fedora Update System 2012-06-03 23:26:00 UTC 
php-channel-phpdoc-1.3-3.fc17 has been pushed to the Fedora 17 stable repository.
Note You need to log in before you can comment on or make changes to this bug.