Created attachment 572545 [details]
engine log

This happens when the image in the configuration is illegal.
For illegal image a new disk is created.
The fix performs the following:
a. Checks that indeed illegal image was created as the disk of the image was removed after the snapshot.
b. In this case - adds the disk without vm device 
c. Vm device will be added later on during vm device copying from the vm configuration (before the fix, this was the reason for the attempt to insert the same vm device twice)

http://gerrit.ovirt.org/#change,3085

merged - commit hash c882ad75c82e6735960d7088d78f017039c43c00

now the cloning succeed but since the snapshot has "illegal" status ,the cloning VM created with one disk only

vm_device table is missing info of one disk



engine=# SELECT vm_guid  from vm_static  where vm_name = 'clone4';
               vm_guid                
--------------------------------------
 b2c70cca-7b8f-420e-82b0-be585986e335
(1 row)

engine=# 
engine=# SELECT * from vm_device where vm_id = 'b2c70cca-7b8f-420e-82b0-be585986e335';
              device_id               |                vm_id                 | type | device | address | boot_order |                  spec_params                  | is_managed | is_plugged | is_readonly 
--------------------------------------+--------------------------------------+------+--------+---------+------------+-----------------------------------------------+------------+------------+-------------
 fc8de9b4-493f-42ff-bccf-320068d82a81 | b2c70cca-7b8f-420e-82b0-be585986e335 | disk | disk   |         |          1 | deviceId=fc8de9b4-493f-42ff-bccf-320068d82a81 | t          | t          | f
(1 row)

Fixed at commit hash e47cbdced478dce1d331c5a7778fd4d1da3a084a

fixed
verified on last dev hash commit b27eef27132cd152d58b6503324a9248374864ab