Bug 808195 - Review Request: nml - NewGRF Meta Language compiler
Review Request: nml - NewGRF Meta Language compiler
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Marcus Moeller
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-29 15:16 EDT by Felix Kaechele
Modified: 2012-04-11 11:32 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-04-11 11:32:41 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
marcus.moeller: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Felix Kaechele 2012-03-29 15:16:37 EDT
Spec URL: http://heffer.fedorapeople.org/review/nml.spec
SRPM URL: http://heffer.fedorapeople.org/review/nml-0.2.3-1.fc18.src.rpm
Description: This is needed to update openttd-opengfx to version 0.4.3 as it has begun using nml.
Comment 1 Marcus Moeller 2012-04-11 06:58:22 EDT
rpmlint -v output:

nml.noarch: I: checking
nml.noarch: W: spelling-error %description -l en_US grf -> gr, gr f
nml.noarch: W: spelling-error %description -l en_US nfo -> no, info
nml.noarch: W: spelling-error %description -l en_US newgrf -> Nerf
nml.noarch: I: checking-url http://dev.openttdcoop.org/projects/nml (timeout 10 seconds)
nml.src: I: checking
nml.src: W: spelling-error %description -l en_US grf -> gr, gr f
nml.src: W: spelling-error %description -l en_US nfo -> no, info
nml.src: W: spelling-error %description -l en_US newgrf -> Nerf
nml.src: I: checking-url http://dev.openttdcoop.org/projects/nml (timeout 10 seconds)
nml.src: I: checking-url http://bundles.openttdcoop.org/nml/releases/0.2.3/nml-0.2.3.src.tar.gz (timeout 10 seconds)
SPECS/nml.spec: I: checking-url http://bundles.openttdcoop.org/nml/releases/0.2.3/nml-0.2.3.src.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

OK so far.

---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    GPLv2+
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum *
    7188dcfffa6037b1a0735a1be1cc7a30  nml-0.2.3.src.tar.gz
    7188dcfffa6037b1a0735a1be1cc7a30  nml-0.2.3.src.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    - Succesfully builds in mock.
    - Koji Scratch build available: http://koji.fedoraproject.org/koji/taskinfo?taskID=3979285
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[.] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: Development files must be in a -devel package.
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[.] SHOULD: If the source package does not include license text(s) as a
    separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The reviewer should test that the package functions as described.
    I assume the packager has tested it.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[+] SHOULD: Your package should contain man pages for binaries/scripts.
Comment 2 Felix Kaechele 2012-04-11 07:09:07 EDT
New Package SCM Request
=======================
Package Name: nml
Short Description: NewGRF Meta Language compiler
Owners: heffer
Branches: f15 f16 f17
InitialCC:
Comment 3 Gwyn Ciesla 2012-04-11 07:59:31 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.