Red Hat Bugzilla – Bug 808451
wrong(?) label on postgresql postmaster.pid file
Last modified: 2014-09-30 19:33:19 EDT
Description of problem:
Version-Release number of selected component (if applicable):
Steps to Reproduce:
# run_init service postgresql status
postmaster is stopped
# restorecon -Rv /var
# run_init service postgresql start
Starting postgresql service: [ OK ]
# restorecon -Rv /var
restorecon reset /var/run/postmaster.5432.pid context system_u:object_r:initrc_var_run_t:s0->system_u:object_r:postgresql_var_run_t:s0
* PID file is not labelled correctly
* PID file is labelled correctly
How would the script run restorecon on the PID file, when that doesn't exist beforehand? If this is a bug, which I doubt, then it seems to me that it should be the province of the selinux policy to get this right to start with.
# grep pidfile= /etc/init.d/postgresql
The init script creates the PID file. Path to the PID file is known. Calling restorecon at the end of start() would be enough.
My point is that the file doesn't exist beforehand and so it is being created under the control of the current security policy. If it's not correctly labeled, that's the fault of the security policy, not this script.
More to the point, since no AVC denial occurs, I suspect that the labeling is just fine and so the real problem is not the actual label but restorecon's opinion of what the label "should be". I wouldn't be too surprised if adding a restorecon here created a problem instead of fixing one.
Anyway, reassigning to selinux-policy to see what they think.
Does postgresql actually write to this file? Or is it just created by the init script?
(In reply to comment #5)
> Does postgresql actually write to this file? Or is it just created by the init script?
At the moment it's created directly by the init script, via code like
echo $pid > "$pidfile"
The whole thing is gone anyway in the systemd implementation, and if anyone complains about that we'd probably have to do something different to make it happen there.
Well then we should leave it labeled as initrc_var_run_t.
Ok, then I will remove the labeling.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.