Bug 809260 - missing newline when running openstack-config-set
Summary: missing newline when running openstack-config-set
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: openstack-keystone
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Alan Pevec
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-04-02 21:39 UTC by Jan van Eldik
Modified: 2012-04-23 13:29 UTC (History)
9 users (show)

Fixed In Version: openstack-keystone-2012.1-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-04-23 13:29:19 UTC
Type: ---


Attachments (Terms of Use)
command line output demonstrating missing newline (915 bytes, text/plain)
2012-04-02 21:39 UTC, Jan van Eldik
no flags Details
add newline when a new section is created (321 bytes, patch)
2012-04-02 22:42 UTC, Jan van Eldik
no flags Details | Diff

Description Jan van Eldik 2012-04-02 21:39:08 UTC
Created attachment 574641 [details]
command line output demonstrating missing newline

Description of problem:

When running 
  openstack-config-set /etc/glance/glance-api.conf paste_deploy flavor keystone
the new entry in /etc/glance/glance-api.conf misses a newline

Version-Release number of selected component (if applicable):

openstack-keystone-2012.1-0.11.rc1.fc16.noarch

How reproducible:

100%

Comment 1 Alan Pevec 2012-04-02 22:14:26 UTC
> the new entry in /etc/glance/glance-api.conf misses a newline

Might not be aesthetically pleasing, but it's a valid config :)
It's what iniparse produces, did you see any issues due to missing newline?

Comment 2 Jan van Eldik 2012-04-02 22:42:04 UTC
No, I did not see any issues because of this. I noticed it when trying
to understand why "glance index" throws a "500 Internal Server Error" at me...

The attached patch adds the missing newline, and makes the result more
easy on the eye.

Comment 3 Jan van Eldik 2012-04-02 22:42:51 UTC
Created attachment 574668 [details]
add newline when a new section is created

Comment 4 Alan Pevec 2012-04-02 23:20:27 UTC
(In reply to comment #3)
> Created attachment 574668 [details]
> add newline when a new section is created

Thanks!
 http://pkgs.fedoraproject.org/gitweb/?p=openstack-keystone.git;a=commitdiff;h=4f532e4ebf03a19923326f4d6c3e1827891f7d89

Comment 5 Alan Pevec 2012-04-23 13:29:19 UTC
openstack-keystone-2012.1-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/FEDORA-2012-4690/openstack-keystone-2012.1-1.fc17


Note You need to log in before you can comment on or make changes to this bug.