Attached patch fixes compilation with httpd-2.4. I've tested it briefly, but you should test it yourself before using the patch and also inform the upstream.
Created attachment 575064 [details] proposed patch
Thanks a lot! One question : Do you really need to hardcode a new default content type, or would it be possible to access the one which is already configured for the server?
Well, as I understand it now, there is no default_type just now for httpd, I will try to google it more to be sure... > ap_default_type() > This is no longer available; Content-Type must be configured explicitly or > added by the application. Note that this patch I sent is only for the compilation problem. You should follow https://fedoraproject.org/wiki/PackagingDrafts/ApacheHTTPModules to convert it properly (I forgot to mention it).
Commit: http://pkgs.fedoraproject.org/gitweb/?p=mod_limitipconn.git;a=commitdiff;h=f43b499a414491d4c1b42be63fd515a198eec591 Package: mod_limitipconn-0.23-7.fc18 Build: https://koji.fedoraproject.org/koji/buildinfo?buildID=313703
Commit: http://pkgs.fedoraproject.org/gitweb/?p=mod_limitipconn.git;a=commitdiff;h=956b60fee7f7ab125b9a789a46f470426b1fc635 Package: mod_limitipconn-0.23-8.fc18 Build: https://koji.fedoraproject.org/koji/buildinfo?buildID=313707
I mailed the patch from -8 upstream, here's my comment on handling absent c-type: "" In 2.4.x there is no concept of a "default" content-type, so I took the approach of ignoring the "no limit" list for a resource with no content-type, and never applying limit checking if an exclusive list is present and the content-type is absent. I hope this makes sense. ""
I am the upstream author. The patch from Jan/Joe seems to work and doesn't break previous httpd versions. I'll release a new upstream in a few days. The delay is just to make sure that no more unexpected problems crop up. I don't know how old a Fedora version you want to try to support, but on Fedora 14 the following additional compatibility macro is required in order for the package to build: %{!?_httpd_moddir: %{expand: %%global _httpd_moddir %%{_libdir}/httpd/modules}} (Fedora 15 and 16 do not need this macro -- I've tested it.) Since the macro does not seem to harm anything on more recent Federa versions, you might consider including it anyway.
Thanks Joe for fixing this one, and David for confirming! David : Once the next upstream release is available, I'll go ahead and update the package, and make sure I include the relevant macro lines to have the same spec build fine on older releases such as RHEL5 (apache httpd 2.2.3 without the _httpd_* globals in the build macros).
Commit: http://pkgs.fedoraproject.org/gitweb/?p=mod_limitipconn.git;a=commitdiff;h=36ea15a752732783f636a0936f04ec1a25ecd1cd Package: mod_limitipconn-0.23-9.fc18 Build: https://koji.fedoraproject.org/koji/buildinfo?buildID=314089
I addded the _httpd_moddir macro too, thanks David for the review.
New upstream version: http://dominia.org/djao/limit/mod_limitipconn-0.24.tar.bz2
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle. Changing version to '19'. (As we did not run this process for some time, it could affect also pre-Fedora 19 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19
This message is a notice that Fedora 19 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 19. It is Fedora's policy to close all bug reports from releases that are no longer maintained. Approximately 4 (four) weeks from now this bug will be closed as EOL if it remains open with a Fedora 'version' of '19'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 19 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.