Bug 810532 - Circular build dependency in perl-Devel-PartialDump-0.15-3.fc18
Circular build dependency in perl-Devel-PartialDump-0.15-3.fc18
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: perl-Devel-PartialDump (Show other bugs)
rawhide
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Iain Arnell
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-06 10:43 EDT by Paul Howarth
Modified: 2012-04-06 12:00 EDT (History)
2 users (show)

See Also:
Fixed In Version: perl-Devel-PartialDump-0.15-4.fc18
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-04-06 12:00:51 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Paul Howarth 2012-04-06 10:43:12 EDT
perl-Devel-PartialDump buildrequires and requires Moose, but Moose itself has a runtime dependency on perl(Devel::PartialDump) and so cannot be used to bootstrap perl-Devel-PartialDump. Suggested fix is to avoid buildreq of Moose and skip the test suite when bootstrapping:

diff --git a/perl-Devel-PartialDump.spec b/perl-Devel-PartialDump.spec
index 18c3912..d27d12d 100644
--- a/perl-Devel-PartialDump.spec
+++ b/perl-Devel-PartialDump.spec
@@ -9,7 +9,13 @@ URL:            http://search.cpan.org/dist/Devel-PartialDump/
 Source0:        http://www.cpan.org/authors/id/F/FL/FLORA/Devel-PartialDump-%{version}.tar.gz
 BuildArch:      noarch
 BuildRequires:  perl(ExtUtils::MakeMaker)
+# Moose has a manual dependency on Devel::PartialDump for enhanced reporting
+# Devel::PartialDump itself requires Moose, so when bootstrapping we do a blind
+# build of Devel::PartialDump without running the test suite, then build Moose,
+# then rebuild Devel::PartialDump with Moose, running the test suite
+%if 0%{!?perl_bootstrap:1}
 BuildRequires:  perl(Moose)
+%endif
 BuildRequires:  perl(namespace::clean) >= 0.20
 BuildRequires:  perl(Sub::Exporter)
 BuildRequires:  perl(Test::use::ok)
@@ -38,7 +44,9 @@ find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
 %{_fixperms} $RPM_BUILD_ROOT/*
 
 %check
+%if 0%{!?perl_bootstrap:1}
 make test
+%endif
 
 %files
 %doc Changes


All packages using %perl_bootstrap should of course be rebuilt without %perl_bootstrap set once the bootstrap build is complete, so we find any FTBFS issues revealed by skipped tests.
Comment 1 Iain Arnell 2012-04-06 12:00:51 EDT
Patch applied and built in rawhide.

Note You need to log in before you can comment on or make changes to this bug.