Bug 810532 - Circular build dependency in perl-Devel-PartialDump-0.15-3.fc18
Summary: Circular build dependency in perl-Devel-PartialDump-0.15-3.fc18
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-Devel-PartialDump
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Iain Arnell
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2012-04-06 14:43 UTC by Paul Howarth
Modified: 2012-04-06 16:00 UTC (History)
2 users (show)

Fixed In Version: perl-Devel-PartialDump-0.15-4.fc18
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2012-04-06 16:00:51 UTC
Type: Bug

Attachments (Terms of Use)

Description Paul Howarth 2012-04-06 14:43:12 UTC
perl-Devel-PartialDump buildrequires and requires Moose, but Moose itself has a runtime dependency on perl(Devel::PartialDump) and so cannot be used to bootstrap perl-Devel-PartialDump. Suggested fix is to avoid buildreq of Moose and skip the test suite when bootstrapping:

diff --git a/perl-Devel-PartialDump.spec b/perl-Devel-PartialDump.spec
index 18c3912..d27d12d 100644
--- a/perl-Devel-PartialDump.spec
+++ b/perl-Devel-PartialDump.spec
@@ -9,7 +9,13 @@ URL:            http://search.cpan.org/dist/Devel-PartialDump/
 Source0:        http://www.cpan.org/authors/id/F/FL/FLORA/Devel-PartialDump-%{version}.tar.gz
 BuildArch:      noarch
 BuildRequires:  perl(ExtUtils::MakeMaker)
+# Moose has a manual dependency on Devel::PartialDump for enhanced reporting
+# Devel::PartialDump itself requires Moose, so when bootstrapping we do a blind
+# build of Devel::PartialDump without running the test suite, then build Moose,
+# then rebuild Devel::PartialDump with Moose, running the test suite
+%if 0%{!?perl_bootstrap:1}
 BuildRequires:  perl(Moose)
 BuildRequires:  perl(namespace::clean) >= 0.20
 BuildRequires:  perl(Sub::Exporter)
 BuildRequires:  perl(Test::use::ok)
@@ -38,7 +44,9 @@ find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
 %{_fixperms} $RPM_BUILD_ROOT/*
+%if 0%{!?perl_bootstrap:1}
 make test
 %doc Changes

All packages using %perl_bootstrap should of course be rebuilt without %perl_bootstrap set once the bootstrap build is complete, so we find any FTBFS issues revealed by skipped tests.

Comment 1 Iain Arnell 2012-04-06 16:00:51 UTC
Patch applied and built in rawhide.

Note You need to log in before you can comment on or make changes to this bug.