Bug 813253 - nm-connection-editor: ask gnome-keyring for credential asynchronously and pop error when g-k does not respond
Summary: nm-connection-editor: ask gnome-keyring for credential asynchronously and pop...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: NetworkManager
Version: 6.3
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: 6.3
Assignee: Dan Williams
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-04-17 10:30 UTC by David Jaša
Modified: 2012-10-04 13:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-10-04 13:45:25 UTC
Target Upstream Version:


Attachments (Terms of Use)
backtrace (20.48 KB, text/plain)
2012-04-17 10:30 UTC, David Jaša
no flags Details

Description David Jaša 2012-04-17 10:30:54 UTC
Created attachment 577986 [details]
backtrace

Description of problem:
nm-connection-editor freezes at various occasions. This particular one is right after hitting "OK" when creating VPN connection

Version-Release number of selected component (if applicable):
NetworkManager-gnome-0.8.1-29.el6.x86_64

How reproducible:
often

Steps to Reproduce:
1. create a new vpn connection
2.
3.
  
Actual results:
nm-connection-editor freezes

Expected results:


Additional info:

Comment 1 David Jaša 2012-04-17 10:48:56 UTC
The report itself is essentially a dupe of these:
https://bugzilla.redhat.com/show_bug.cgi?id=574449
https://bugzilla.redhat.com/show_bug.cgi?id=767096

but it should be fixed in nm-c-e too, because g-k is a separate component and relying on it too much is against principles of robustness.

Comment 2 Tomáš Bžatek 2012-04-17 11:38:55 UTC
(In reply to comment #1)
> but it should be fixed in nm-c-e too, because g-k is a separate component and
> relying on it too much is against principles of robustness.

NetworkManager should do gnome-keyring calls async at a first place.

Comment 3 Dan Williams 2012-04-19 23:25:55 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > but it should be fixed in nm-c-e too, because g-k is a separate component and
> > relying on it too much is against principles of robustness.
> 
> NetworkManager should do gnome-keyring calls async at a first place.

It should, and it does now with NM 0.9 and later due to a rewrite of those areas.  Unfortunately it's a lot harder to make the functions async in the old code, and backporting doesn't work because it's been entirely rewritten.

But here, while making the calls async would paper over things, the core problem is actually a bug in the gnome-keyring libraries that got fixed later than RHEL6.  Even if we made the calls async we'd still have the keyring issue.  IIRC this happened in Fedora for a while too, not just with NetworkManager.  It eventually got fixed and the problem went away, long before the applet/editor rewrite that made the keyring calls async.

Comment 4 Suzanne Logcher 2012-05-18 20:54:27 UTC
This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.

Comment 5 Tomáš Bžatek 2012-10-04 13:45:25 UTC
(In reply to comment #3)
> It should, and it does now with NM 0.9 and later due to a rewrite of those
> areas.  Unfortunately it's a lot harder to make the functions async in the
> old code, and backporting doesn't work because it's been entirely rewritten.

Sure, no need to break a whole lot of code in a stable release.

Closing this bugreport since the core issue in gnome-keyring-daemon has been fixed (bug 574449).


Note You need to log in before you can comment on or make changes to this bug.