Hide Forgot
Description of problem: Per the packaging guidelines we should run the test suite as part of the build. This should be done in the spec file's %check section and the build should fail if any test fails. QE runs the test as part of a shell script afterwards but it's best to do that and build time. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. Build nspr with repmbuild --rebuild path-to-nspr-source-rpm Actual results: No tests are run Expected results: The test suite is run Additional info: We already do that for rhel 6.x, we should do likewise.
Created attachment 578083 [details] Changes to spec file to run the tests in patch form
Comment on attachment 578083 [details] Changes to spec file to run the tests in patch form r=kaie
Our own Packaging Guidelines require that on the spec file's %check section we run the test suite that upstream provides. It's time we comply with such good practice on RHEL-5.x as we already do on RHEL-6.x.
This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate, in the next release of Red Hat Enterprise Linux.
Fixed with nspr-4.9.5-2.el5 as part of fixing Bug 737704.
Funny, I have been asked to verify as as I was the bug reporter. I verified by examining http://download.devel.redhat.com/brewroot/packages/nspr/4.9.5/2.el5/data/logs/s390/build.log As you can see the nspr usptream test suite was executed. Had any test failed the build would have failed.