Red Hat Bugzilla – Bug 813873
New logging action with detailed debug and trace output
Last modified: 2014-10-15 13:26:16 EDT
Description of problem: https://issues.jboss.org/browse/JBESB-3728 New logging action with detailed debug and trace output Fixed in ER1 - this bz is logged to track the fix and to ensure QE verifies Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Functionality is present but with a bug in constructor currCategoryName = configTree.getAttribute(ListenerTagNames.SERVICE_CATEGORY_NAME_TAG); currActionName = configTree.getAttribute(ListenerTagNames.ACTION_ELEMENT_TAG); There is no category attribute on action element
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: There is now a new logging action with detailed debug and trace output that can be added to the action chain.
The code has been changed to: public ServiceLoggerAction(ConfigTree configTree) { myLogger = Logger.getLogger(configTree.getParent().getAttribute( ListenerTagNames.SERVICE_CATEGORY_NAME_TAG) + "." + configTree.getParent().getAttribute(ListenerTagNames.SERVICE_NAME_TAG)); currActionName = configTree.getAttribute(ListenerTagNames.ACTION_ELEMENT_TAG); printlnMessage = configTree.getAttribute(PRE_MESSAGE, currActionName); payloadProxy = new MessagePayloadProxy(configTree); }
Technical note updated. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1,2 +1 @@ -There is now a new logging action with +There is now a new logging action with detailed debug and trace output that can be added to the action chain.-detailed debug and trace output that can be added to the action chain.
myLogger = Logger.getLogger(configTree.getParent().getAttribute( ListenerTagNames.SERVICE_CATEGORY_NAME_TAG) + "." + configTree.getParent().getAttribute(ListenerTagNames.SERVICE_NAME_TAG)); Line currCategoryName = configTree.getAttribute(ListenerTagNames.SERVICE_CATEGORY_NAME_TAG); should be currCategoryName = configTree.getAttribute(configTree.getParent().getAttribute(ListenerTagNames.SERVICE_CATEGORY_NAME_TAG)); One more question - why do you concat category and action name? Would not it make more sense to concat service and action name? Or category, service and action?
Technical note updated. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1 +1,2 @@ -There is now a new logging action with detailed debug and trace output that can be added to the action chain.+There is now a new logging action with +detailed debug and trace output that can be added to the action chain.
public static final String LOG_PAYLOAD_LOCATION_TAG = "get-payload-location"; this line is wrong. The name of the property conflicts with public static final String GET_PAYLOAD_LOCATION = "get-payload-location"; as defined in MessagePayloadProxy The property as define in ServiceLoggerAction expects to be true/false and is flag to enable logging of the payload location. Unfortunately it overwrites the location that is expected by MessagePayloadProxy
Fixed the issue Jiri talks about above, and also changed the log4j category to <JBOSSESB-COMMON-STRING>.<DEPLOYMENT> .<SERVICE-CATEGORY>.<SERVICE-NAME> so that we can filter by deployment and provide a case where all ServiceLoggerActions are configured.
Please verify this issue on 5.3.0 CR1.
Verified in CR1