Bug 813873 - New logging action with detailed debug and trace output
Summary: New logging action with detailed debug and trace output
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise SOA Platform 5
Classification: JBoss
Component: JBossESB
Version: 5.3.0 GA
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: CR1
: 5.3.0 GA
Assignee: tcunning
QA Contact: Jiri Pechanec
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-04-18 15:59 UTC by Len DiMaggio
Modified: 2014-10-15 17:26 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
There is now a new logging action with detailed debug and trace output that can be added to the action chain.
Clone Of:
Environment:
Last Closed: 2014-10-15 17:26:16 UTC
Type: Bug


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker JBESB-3728 0 Minor Closed New logging action with detailed debug and trace output 2012-07-26 04:59:50 UTC

Description Len DiMaggio 2012-04-18 15:59:50 UTC
Description of problem:

https://issues.jboss.org/browse/JBESB-3728 New logging action with
detailed debug and trace output
Fixed in ER1 - this bz is logged to track the fix and to ensure QE verifies

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jiri Pechanec 2012-06-05 11:43:33 UTC
Functionality is present but with a bug in constructor

		
currCategoryName = configTree.getAttribute(ListenerTagNames.SERVICE_CATEGORY_NAME_TAG);
currActionName = configTree.getAttribute(ListenerTagNames.ACTION_ELEMENT_TAG);

There is no category attribute on action element

Comment 2 David Le Sage 2012-07-02 04:59:27 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
There is now a new logging action with
detailed debug and trace output that can be added to the action chain.

Comment 3 Len DiMaggio 2012-07-16 20:31:08 UTC
The code has been changed to:

public ServiceLoggerAction(ConfigTree configTree) {

	myLogger = Logger.getLogger(configTree.getParent().getAttribute(
		ListenerTagNames.SERVICE_CATEGORY_NAME_TAG)
		+ "."
		+ configTree.getParent().getAttribute(ListenerTagNames.SERVICE_NAME_TAG));

	currActionName = configTree.getAttribute(ListenerTagNames.ACTION_ELEMENT_TAG);

	printlnMessage = configTree.getAttribute(PRE_MESSAGE, currActionName);

	payloadProxy = new MessagePayloadProxy(configTree);
}

Comment 4 Jiri Pechanec 2012-07-18 07:54:56 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,2 +1 @@
-There is now a new logging action with
+There is now a new logging action with
detailed debug and trace output that can be added to the action chain.-detailed debug and trace output that can be added to the action chain.

Comment 5 Jiri Pechanec 2012-07-18 14:28:11 UTC
 myLogger = Logger.getLogger(configTree.getParent().getAttribute(
                                ListenerTagNames.SERVICE_CATEGORY_NAME_TAG) + "."
                                + configTree.getParent().getAttribute(ListenerTagNames.SERVICE_NAME_TAG));

Line
currCategoryName = configTree.getAttribute(ListenerTagNames.SERVICE_CATEGORY_NAME_TAG);

should be
currCategoryName = configTree.getAttribute(configTree.getParent().getAttribute(ListenerTagNames.SERVICE_CATEGORY_NAME_TAG));

One more question - why do you concat category and action name? Would not it make more sense to concat service and action name? Or category, service and action?

Comment 6 Douglas Palmer 2012-07-18 21:36:19 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1,2 @@
-There is now a new logging action with
detailed debug and trace output that can be added to the action chain.+There is now a new logging action with
+detailed debug and trace output that can be added to the action chain.

Comment 7 Jiri Pechanec 2012-07-19 11:59:56 UTC
public static final String LOG_PAYLOAD_LOCATION_TAG = "get-payload-location";

this line is wrong. The name of the property conflicts with
public static final String GET_PAYLOAD_LOCATION = "get-payload-location";

as defined in MessagePayloadProxy

The property as define in ServiceLoggerAction expects to be true/false and is flag to enable logging of the payload location. Unfortunately it overwrites the location that is expected by MessagePayloadProxy

Comment 8 Jiri Pechanec 2012-07-19 11:59:56 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,2 +1 @@
-There is now a new logging action with
+There is now a new logging action with
detailed debug and trace output that can be added to the action chain.-detailed debug and trace output that can be added to the action chain.

Comment 9 Jiri Pechanec 2012-07-19 12:02:27 UTC
public static final String LOG_PAYLOAD_LOCATION_TAG = "get-payload-location";

this line is wrong. The name of the property conflicts with
public static final String GET_PAYLOAD_LOCATION = "get-payload-location";

as defined in MessagePayloadProxy

The property as define in ServiceLoggerAction expects to be true/false and is flag to enable logging of the payload location. Unfortunately it overwrites the location that is expected by MessagePayloadProxy

Comment 10 tcunning 2012-07-19 16:58:10 UTC
Fixed the issue Jiri talks about above, and also changed the log4j category to <JBOSSESB-COMMON-STRING>.<DEPLOYMENT>
.<SERVICE-CATEGORY>.<SERVICE-NAME> so that we can filter by deployment and provide a case where all ServiceLoggerActions are configured.

Comment 11 tcunning 2012-07-19 16:58:10 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1,2 @@
-There is now a new logging action with
detailed debug and trace output that can be added to the action chain.+There is now a new logging action with
+detailed debug and trace output that can be added to the action chain.

Comment 12 Ryan Zhang 2012-07-20 06:35:09 UTC
Please verify this issue on 5.3.0 CR1.

Comment 13 Jiri Pechanec 2012-07-23 11:16:24 UTC
Verified in CR1


Note You need to log in before you can comment on or make changes to this bug.