Bug 814765 - %makeinstall doesn't set ${htmldir}
Summary: %makeinstall doesn't set ${htmldir}
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: rpm
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fedora Packaging Toolset Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-04-20 15:32 UTC by David Woodhouse
Modified: 2012-05-08 11:58 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-05-08 11:58:28 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description David Woodhouse 2012-04-20 15:32:41 UTC
We don't seem to set DESTDIR when running 'make install'. Instead, the %makeinstall macro overrides a bunch of the standard directories that autoconf sets. 

With openconnect configured with
%configure --htmldir=%{_docdir}/%{name}-%{version}

...installation fails, because it ends up trying to install into the root instead of into $RPM_BUILD_ROOT. If we were using DESTDIR for installation, this would have worked fine... isn't that what DESTDIR is *for*?

I've worked around it by setting --htmldir='${datadir}/doc/%{name}-%{version}', so that $datadir is expanded by make at 'make install' time, and does pick up the value that's overridden by %makeinstall. But that doesn't seem right...

Comment 1 Panu Matilainen 2012-04-21 05:57:32 UTC
http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

All current Fedora versions support %make_install macro which does the "right thing":

%make_install %{__make} install DESTDIR=%{?buildroot}

Comment 2 Panu Matilainen 2012-05-08 11:58:28 UTC
WONTFIX, like noted %makeinstall is plain broken and only kept around for backwards compatibility, new packages shouldn't use it at all so there's little reason to "fix" it to work with newer auto*tools.


Note You need to log in before you can comment on or make changes to this bug.