Created attachment 579988 [details]
Allow nanny to write to syslog when --nodaemon option is specified.

When a sorry_server is defined, lvsd will start nanny with the --nodaemon option. This caused nanny to not write information to syslog. This problem is a result of two problems in the code:

1. The LVS_FLAG_SYSLOG was not being set when --nodaemon was specified.\
2. The piranha_log function would write log messages to stdout or syslog, but not both.

This patch fixes both of these problems. Note that the va_start and va_end must be moved into each if block in order to avoid segfault.

Test results with patch provided in comment #4:

# grep sorry_server /etc/sysconfig/ha/lvs.cf 
     sorry_server = 192.168.1.101

# service pulse start
Starting pulse:                                            [  OK  ]

From /var/log/messages ...

Apr 24 15:09:27 node-06 lvs[6426]: starting virtual service VIP_201 active: 80
Apr 24 15:09:27 node-06 lvs[6426]: create_monitor for VIP_201/mobil-virt-08 running as pid 6436
Apr 24 15:09:27 node-06 lvs[6426]: create_monitor for VIP_201/mobil-virt-09 running as pid 6437
Apr 24 15:09:27 node-06 nanny: starting LVS client monitor for 192.168.1.201:80 -> 192.168.1.109:80
Apr 24 15:09:27 node-06 nanny: starting LVS client monitor for 192.168.1.201:80 -> 192.168.1.108:80
Apr 24 15:09:27 node-06 nanny: [ active ] making 192.168.1.108:80 available
Apr 24 15:09:27 node-06 nanny: [ active ] making 192.168.1.109:80 available

This is correct.

Created attachment 580274 [details]
Call openlog whenever LVS_FLAG_SYSLOG is set

Currently, openlog is called within the daemonize function. Since defining a sorry_server in lvs.cf causes nanny to be called with the --nodaemon option, daemonize will not be called and therefore openlog will not be called, regardless of LVS_FLAG_SYSLOG. While it is perfectly acceptable to call syslog without calling openlog first, you'll noticed that messages logged from nanny will not report the pid since openlog was not called with LOG_PID option.

Solution is to call openlog outside of daemonize. This patch removes openlog from daemonize and calls openlog directly from each process is LVS_FLAG_SYSLOG is set.

With only patch from comment #4 and lvs.cf where sorry_server is defined, openlog is not called so log messages from nanny will not have pid included:

Apr 25 11:43:17 node-06 nanny: [ active ] making 192.168.1.108:80 available
Apr 25 11:43:17 node-06 nanny: [ active ] making 192.168.1.109:80 available

With patch from comment #10, openlog is always called is LVS_FLAG_SYSLOG and regardless if process calls daemonize. Note that the pid is included in each message.

Apr 25 15:02:28 node-06 nanny[8173]: [ active ] making 192.168.1.109:80 available
Apr 25 15:02:28 node-06 nanny[8172]: [ active ] making 192.168.1.108:80 available

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0891.html