Red Hat Bugzilla – Bug 821534
RFE: Consider increasing rhq_config_property.string_value to a 4000 character limit
Last modified: 2015-02-01 18:29:38 EST
At the moment we are using a varchar2( 2000 ) in Oracle and character varying (2000) in Postgres for rhq_config_property.string_value.
This is pretty reasonable but there may be times when our LongString config prop type may want to accommodate large values. An example is perhaps the values for our new StartScriptEnv and StartScriptArg fields in the AS5 and AS7 plugins.
This should not affect space consumption as varying chars basically take up their length plus a small overhead for storing size. There is not a lot of indication that this change would affect performance at all since config prop values are not indexed.
Oracle allows a 4000 max, so that would be the target size even though Postgres allows higher.
Still, given the critical nature of Configuration, and the already slow recursiveness of the sructure, a change probably warrants some perf analysis and upgrade checking.
Here's a couple links that support the claim that this change would not have any negative performance impact:
If we bump up the max, we should also bump up the following column in RHQ_CONFIG_PROP_DEF:
<column name="DEFAULT_VALUE" type="VARCHAR2" required="false" size="2000"/>
We should also do a grep of the entire code base for the string "2000" in case there are any other references to the old max that need to be updated.
(10:29:44 AM) ips: i think we should also consider increasing propdef.description
(10:29:59 AM) ips: that's currently only 1000
(10:30:10 AM) jshaughn: yeah, there no reason to limit that
(10:30:23 AM) ips: well i guess all the description columns - operation, metric, etc.
(10:30:38 AM) jshaughn: sure, no real reason to limit description text
(10:30:57 AM) ips: nope