Bug 82192 - broken source code
Summary: broken source code
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: ruby
Version: 8.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Akira TAGOH
QA Contact: Bill Huang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2003-01-19 10:47 UTC by d.binderman
Modified: 2007-04-18 16:50 UTC (History)
0 users

Fixed In Version: 1.6.8-7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2003-07-04 17:00:01 UTC
Embargoed:


Attachments (Terms of Use)

Description d.binderman 2003-01-19 10:47:03 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.6 [en-gb]C-CCK-MCD NetscapeOnline.co.uk  (Win98; I)

Description of problem:

Hello there,

I just tried to compile package ruby-1.6.7-10 from Redhat 8.0

The compiler said

ruby.c:914: warning: operation on `s' may be undefined

Here is an untested patch to shut up the compiler.

*** ./ruby-1.6.7/ruby.c.old	2003-01-19 09:34:17.000000000 +0000
--- ./ruby-1.6.7/ruby.c	2003-01-19 09:35:02.000000000 +0000
***************
*** 911,917 ****
  	/* See if all the arguments are contiguous in memory */
  	for (i = 1; i < origargc; i++) {
  	    if (origargv[i] == s + 1)
! 		s += strlen(++s);	/* this one is ok too */
  	}
  	len = s - origargv[0];
      }
--- 911,920 ----
  	/* See if all the arguments are contiguous in memory */
  	for (i = 1; i < origargc; i++) {
  	    if (origargv[i] == s + 1)
! 	    {
! 		++s;
! 		s += strlen( s);	/* this one is ok too */
! 	    }
  	}
  	len = s - origargv[0];
      }

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. compile the program
2.
3.
    

Additional info

Comment 1 Akira TAGOH 2003-07-04 17:00:01 UTC
Fixed.


Note You need to log in before you can comment on or make changes to this bug.