Bug 822878 - Review Request: perl-Task-Kensho-OOP - A Glimpse at an Enlightened Perl (OOP)
Summary: Review Request: perl-Task-Kensho-OOP - A Glimpse at an Enlightened Perl (OOP)
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 822585
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-05-18 11:30 UTC by Jitka Plesnikova
Modified: 2012-05-24 15:08 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-05-24 15:08:56 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jitka Plesnikova 2012-05-18 11:30:20 UTC
Spec URL: http://jplesnik.fedorapeople.org/perl-Task-Kensho-OOP.spec
SRPM URL: http://jplesnik.fedorapeople.org/perl-Task-Kensho-OOP-0.28-1.fc18.src.rpm
Description: Task::Kensho is a first cut at building a list of recommended modules for Enlightened Perl development. This Task installs object oriented programming modules.

Comment 1 Petr Pisar 2012-05-23 15:53:05 UTC
Source file is original. Ok.
Summary verified from lib/Task/Kensho/OOP.pm. Ok.
License verified from lib/Task/Kensho/OOP.pm. Ok.
Description is Ok.
URL and Source0 are usable. Ok.
No XS code, noarch BuildArch is Ok.
BuildRequires are Ok.

All tests pass. Ok.


$ rpmlint perl-Task-Kensho-OOP.spec ../SRPMS/perl-Task-Kensho-OOP-0.28-1.fc18.src.rpm ../RPMS/noarch/perl-Task-Kensho-OOP-0.28-1.fc18.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Task-Kensho-OOP-0.28-1.fc18.noarch.rpm 
drwxr-xr-x    2 root    root                        0 May 23 17:45 /usr/share/doc/perl-Task-Kensho-OOP-0.28
-rw-r--r--    1 root    root                     3245 Mar 26  2011 /usr/share/doc/perl-Task-Kensho-OOP-0.28/Changes
-rw-r--r--    1 root    root                     1485 Jan 20  2011 /usr/share/doc/perl-Task-Kensho-OOP-0.28/README
-rw-r--r--    1 root    root                     3275 May 23 17:45 /usr/share/man/man3/Task::Kensho::OOP.3pm.gz
drwxr-xr-x    2 root    root                        0 May 23 17:45 /usr/share/perl5/vendor_perl/Task
drwxr-xr-x    2 root    root                        0 May 23 17:45 /usr/share/perl5/vendor_perl/Task/Kensho
-rw-r--r--    1 root    root                     3127 Mar 26  2011 /usr/share/perl5/vendor_perl/Task/Kensho/OOP.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Task-Kensho-OOP-0.28-1.fc18.noarch.rpm |sort |uniq -c
      1 perl(:MODULE_COMPAT_5.14.2)
      1 perl(strict)
      1 perl(Task::Moose)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Task-Kensho-OOP-0.28-1.fc18.noarch.rpm |sort |uniq -c
      1 perl(Task::Kensho::OOP) = 0.28
      1 perl-Task-Kensho-OOP = 0.28-1.fc18
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Task-Kensho-OOP-0.28-1.fc18.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4096652). Ok.

Package is in line with Fedora and Perl packaging guidelines.


Resolution: Package APPROVED.

Comment 2 Jitka Plesnikova 2012-05-24 06:32:19 UTC
New Package SCM Request
=======================
Package Name: perl-Task-Kensho-OOP
Short Description: A Glimpse at an Enlightened Perl (OOP)
Owners: jplesnik mmaslano ppisar psabata
Branches:
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2012-05-24 14:36:39 UTC
Git done (by process-git-requests).

Comment 4 Jitka Plesnikova 2012-05-24 15:08:56 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.