Bug 822934 - Client wizard needs unit tests
Summary: Client wizard needs unit tests
Keywords:
Status: CLOSED DUPLICATE of bug 829925
Alias: None
Product: OKD
Classification: Red Hat
Component: oc
Version: 2.x
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: John (J5) Palmieri
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-05-18 14:56 UTC by Clayton Coleman
Modified: 2015-05-15 01:54 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-18 18:39:40 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Clayton Coleman 2012-05-18 14:56:44 UTC
need rspec tests around the wizard flow - i.e. everything that is not part of wizard should be mocked and the correct flow should be tested.

You may need to introduce fakefs to test filesystem ops (which is what heroku and some others do), but at a minimum we need to have a unit test that validates that the various failure paths are checked.  i'd prefer everything be mocked except the item under test.  If you hit coverage issues with the tests (have to have 100% to pass) then remove the requires from wizard and ensure the module calling it mocks out those classes.

Comment 1 John (J5) Palmieri 2012-05-24 21:04:13 UTC
Halfway through this.  Wizard spec tests are running in my fork (soon to be merged) but it will take the rest of teh sprint to get close to 100% coverage.

Comment 2 Fabiano Franz 2012-05-30 15:57:53 UTC
Lowering severity so this doesn't block the release.

Comment 3 Clayton Coleman 2012-06-18 18:39:40 UTC

*** This bug has been marked as a duplicate of bug 829925 ***


Note You need to log in before you can comment on or make changes to this bug.