Bug 823471 - Doesn't build from sources
Summary: Doesn't build from sources
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: pycdio
Version: el6
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jay Greguske
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-05-21 10:35 UTC by Mathieu Bridon
Modified: 2012-08-31 18:28 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-31 18:28:27 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Fix the package build, to apply directly in the fedpkg cloned git tree. (1.02 KB, patch)
2012-05-21 11:15 UTC, Mathieu Bridon
no flags Details | Diff

Description Mathieu Bridon 2012-05-21 10:35:35 UTC
Description of problem:
When trying to build the package from the el6 branch in the Fedora git, I get:

$ fedpkg prep
[... snip ...]
Patch #0 (pycdio-remove-shebangs.patch):
+ /bin/cat /home/mathieu/Workspace/dist-git/pycdio/pycdio-remove-shebangs.patch
+ /usr/bin/patch -s -p0 --fuzz=0
1 out of 1 hunk FAILED -- saving rejects to file cdio.py.rej
1 out of 1 hunk FAILED -- saving rejects to file iso9660.py.rej
error: Bad exit status from /var/tmp/rpm-tmp.WMa311 (%prep)


Version-Release number of selected component (if applicable):
Latest in the el6 git branch


Additional info:
This really makes me wonder how it's been built at all :-/
http://koji.fedoraproject.org/koji/buildinfo?buildID=171029

A scratch build from the same sources just doesn't build at all:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4091103

Comment 1 Mathieu Bridon 2012-05-21 11:14:03 UTC
(In reply to comment #0)
> A scratch build from the same sources just doesn't build at all:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=4091103

Oh, it seems it was built from CVS and the patch has that VCS keyword thing (the "$id: .... $"), which is reponsible for it not applying any more. Probably at the time of CVS this wasn't causing any problem?

Anyway, fix is trivial, see attached patch (to apply directly in the fedpkg cloned tree)

Comment 2 Mathieu Bridon 2012-05-21 11:15:23 UTC
Created attachment 585784 [details]
Fix the package build, to apply directly in the fedpkg cloned git tree.

Comment 3 Jay Greguske 2012-05-21 13:23:31 UTC
Thanks for the correction; I'll get to it some time this week.

Comment 4 Jay Greguske 2012-05-22 19:32:08 UTC
Patch applied and the sources are corrected. I guess it got mangled during the dist-cvs to dist-git conversion. Thanks for the assistance.


Note You need to log in before you can comment on or make changes to this bug.