Spec URL: http://threebean.org/rpm/php-zmq.spec SRPM URL: http://threebean.org/rpm/php-zmq-0.6.0-2.20120613git516bd6f.fc17.src.rpm Description: PHP extension for the 0MQ/zmq/zeromq messaging system Fedora Account System Username: ralph rpmlint output: --- devel/php-zmq ‹master* ⁇› » rpmlint php-zmq.spec ~/rpmbuild/SRPMS/php-zmq-0.6.0-2.20120613git516bd6f.fc17.src.rpm php-zmq.spec: W: invalid-url Source0: php-zmq-0.6.0-2.20120613git516bd6f.tar.gz php-zmq.src: W: spelling-error Summary(en_US) zeromq -> zero php-zmq.src: W: spelling-error %description -l en_US zeromq -> zero php-zmq.src: W: invalid-url Source0: php-zmq-0.6.0-2.20120613git516bd6f.tar.gz 1 packages and 1 specfiles checked; 0 errors, 4 warnings. --- devel/php-zmq ‹master* ⁇› » rpmlint /var/lib/mock/fedora-17-x86_64/result/*.rpm php-zmq.src: W: spelling-error Summary(en_US) zeromq -> zero php-zmq.src: W: spelling-error %description -l en_US zeromq -> zero php-zmq.src: W: invalid-url Source0: php-zmq-0.6.0-2.20120613git516bd6f.tar.gz php-zmq.x86_64: W: private-shared-object-provides /usr/lib64/php/modules/zmq.so zmq.so()(64bit) 3 packages and 0 specfiles checked; 0 errors, 4 warnings. koji f17 - http://koji.fedoraproject.org/koji/taskinfo?taskID=4157397 koji el6 - http://koji.fedoraproject.org/koji/taskinfo?taskID=4157400
- rpmlint checks return: See above. All ok except for the private-shared-object-provides. - package meets naming guidelines - package meets packaging guidelines - license ( BSD ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR FIX no unnecessary BR No need to BR gcc - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Otherwise it looks good, just the spurious gcc BR and the provides.
Oh, also License should be BSD and PHP, run-tests.php is PHP.
A new release: SPEC: http://threebean.org/rpm/php-zmq.spec SRPM: http://threebean.org/rpm/php-zmq-0.6.0-3.20120613git516bd6f.fc17.src.rpm Includes: - Updated License to BSD and PHP. - Removed spurious gcc BuildRequires. - Attempt to fix private-shared-object-provides. I've tried a number of different ways now and I just can't figure out the private-shared-object-provides rpmlint warning. I'm stumped; if you have any suggestions, please let me know.
Add: %filter_from_provides /^zmq.so/d %filter_setup To the beginning. https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering
That did it! Thanks for the help and the review. SPEC: http://threebean.org/rpm/php-zmq.spec SRPM: http://threebean.org/rpm/php-zmq-0.6.0-4.20120613git516bd6f.fc17.src.rpm
Anytime. APPROVED.
New Package SCM Request ======================= Package Name: php-zmq Short Description: PHP 0MQ/zmq/zeromq extension Owners: ralph Branches: f17 el6 InitialCC:
Git done (by process-git-requests).
I forgot to mark the bug number in bodhi, but this has been pushed to testing. https://admin.fedoraproject.org/updates/FEDORA-2012-9583/php-zmq-0.6.0-4.20120613git516bd6f.fc17 https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-6182/php-zmq-0.6.0-4.20120613git516bd6f.el6