Bug 833435 - TasksAdminImpl commits trnx even if it's not owner
Summary: TasksAdminImpl commits trnx even if it's not owner
Keywords:
Status: VERIFIED
Alias: None
Product: JBoss Enterprise BRMS Platform 5
Classification: JBoss
Component: jBPM 5
Version: BRMS 5.3.0.GA
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Kris Verlaenen
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-19 13:08 UTC by Jeffrey Bride
Modified: 2023-05-31 22:25 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-03 11:53:07 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Jeffrey Bride 2012-06-19 13:08:33 UTC 
hi,
  in regards to org.jbpm.task.admin.TasksAdminImpl.archiveTasks() .... seems that line 86 should set:  
  boolean txOwner = tpm.beginTransaction();

and then in line 95:  
   tpm.endTransaction(txOwner);

 otherwise, with the current code,  the JTA trnx is always commited at this point even if this piece of code did not start the trnx

same goes for, TasksAdminImpl.removeTasks()
Comment 2 Marco Rietveld 2012-07-02 08:46:39 UTC 
I saw this as well, but thought that maybe Mauricio had a specific reason for writing it this way, given that all other code is written the way Jeffrey mentions. 

Assigning to Mauricio so he can explain.
Comment 3 Mauricio Salatino 2012-07-02 10:48:21 UTC 
Jeff you are correct. I will fix that in master. Thanks for pointing that out. After writing the TaskEventsAdmin class which is similar, I've added a TODO to fix that, so I will do that today.

Cheers
Comment 4 Mauricio Salatino 2012-07-03 11:53:07 UTC 
It's already fixed in master
Comment 6 Mauricio Salatino 2012-08-24 06:56:04 UTC 
Fixed in 5.2.x
Comment 7 Radovan Synek 2012-10-01 07:45:04 UTC 
Verified on 5.3.1.BRMS-ER1
Comment 10 PnT Account Manager 2017-12-07 23:33:56 UTC 
Employee 'msalatin' has left the company.
Note You need to log in before you can comment on or make changes to this bug.