Spec URL: http://people.redhat.com/vondruch/rubygem-heroku-api.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-heroku-api-0.2.6-1.fc18.src.rpm Description: Ruby Client for the Heroku API Fedora Account System Username: vondruch Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4192205
Taking this one.
- The package should have Provides: bundled(okjson), see the lib/heroku/api/vendor dir. AFAIK okjson has already been approved by FPC to be a copylib, so adding the provide should be fine. - %{gem_instdir}/README.md and %{gem_instdir}/changelog.txt should be marked as %doc. Otherwise the package looks good. Since the mentioned issues are not a blocker, this package is APPROVED (but please fix them before commiting).
Good catches! I'll fixed them already in my spec file. Thank you for your review! New Package SCM Request ======================= Package Name: rubygem-heroku-api Short Description: Ruby Client for the Heroku API Owners: vondruch Branches: InitialCC:
Git done (by process-git-requests). Bohuslav, please take ownership of review BZs. Thanks!
(In reply to comment #4) > Git done (by process-git-requests). > > Bohuslav, please take ownership of review BZs. Thanks! Ah, sorry... took it.