Bug 835373 - console logs are not cleared when manually provisioning
Summary: console logs are not cleared when manually provisioning
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: lab controller
Version: 0.9
Hardware: Unspecified
OS: Unspecified
urgent
unspecified
Target Milestone: ---
Assignee: Dan Callaghan
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-26 05:19 UTC by Dan Callaghan
Modified: 2019-05-22 13:43 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-20 00:39:02 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 821948 0 unspecified CLOSED [BUG] fails to clear console logs 2021-02-22 00:41:40 UTC

Internal Links: 821948

Description Dan Callaghan 2012-06-26 05:19:10 UTC
As of commit 92dcec89 the clearing of console logs is tied to the watchdog log monitoring, rather than using the command queue. This fixed a race between the logs being cleared and the watchdog starting to monitor the log -- but it means the logs are never cleared when manually provisioning.

One possibility we have discussed is to put clear_logs back into the command queue, and change things so that the watchdog kill_time is initialised as a callback from the reboot command instead of when the recipe is started by beakerd. This will fix the race (because the watchdog won't be picked up until kill_time is not NULL, by which point the logs will have been cleared) and it will also allow us to clear logs for manual provisions.

Comment 1 Dan Callaghan 2012-07-11 23:53:55 UTC
(In reply to comment #0)
> As of commit 92dcec89 the clearing of console logs is tied to the watchdog
> log monitoring, rather than using the command queue. This fixed a race
> between the logs being cleared and the watchdog starting to monitor the log
> -- but it means the logs are never cleared when manually provisioning.

This is quite a serious bug because of the following situation:

* User manually reserves a system
* User plays around, triggers a panic somehow
* User returns the system, but log is *not* cleared
* Scheduler picks the system for a job
* Watchdog sees panic in old console log and aborts the job

Comment 2 Dan Callaghan 2012-07-12 03:06:56 UTC
On Gerrit: http://gerrit.beaker-project.org/1204

Comment 5 Dan Callaghan 2012-07-20 00:39:02 UTC
Beaker 0.9.1 has been released.


Note You need to log in before you can comment on or make changes to this bug.