RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 842012 - irqbalance segfault from off-by-one malloc
Summary: irqbalance segfault from off-by-one malloc
Keywords:
Status: CLOSED DUPLICATE of bug 843379
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: irqbalance
Version: 6.3
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: rc
: ---
Assignee: Petr Holasek
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-07-20 21:16 UTC by Alex Williamson
Modified: 2016-10-04 04:08 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-02 21:30:27 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Alex Williamson 2012-07-20 21:16:35 UTC
Description of problem:
classify.c:int find_class(struct interrupt *irq, char *moduletext)
{
        ...
        /* Or biosdevname? */
        netdev = malloc(strlen(moduletext));
                        ^^^^^^^^^^^^^^^^^^

strlen does not include terminator

        if (netdev) {
                strcpy(netdev, moduletext);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^

strcpy does include terminator, oops

                 c = netdev;
                 while (*c && (isalnum(*c) || *c == '_')) {
                        c++;
                 }
                 /* Cut possible name suffix */
                 *c = '\0';
                 is_netdev = dev_to_bus(netdev, busname);
                 if (!is_netdev)
                        guess = IRQ_ETH;
                 free(netdev);
                 ^^^^^^^^^^^^^

libc gets very upset about corrupt memory here
        }

Fix is a simple +1 on the malloc

Version-Release number of selected component (if applicable):
irqbalance-0.55-34.el6.x86_64

How reproducible:
100%


Steps to Reproduce:
1. run kvm device assignment, irqbalance in the host bombs
2.
3.
  
Actual results:
segfault

Expected results:
works

Additional info:

Comment 7 Petr Holasek 2012-08-02 21:30:27 UTC
Closing as duplicate of #843379.

John, I'll paste your last comment there.

*** This bug has been marked as a duplicate of bug 843379 ***


Note You need to log in before you can comment on or make changes to this bug.