Bug 842092 - libimobiledevice does not build with Cython 0.16
Summary: libimobiledevice does not build with Cython 0.16
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libimobiledevice
Version: 17
Hardware: All
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Peter Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-07-21 22:02 UTC by Alan Hamilton
Modified: 2013-04-13 08:27 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-04-13 08:27:28 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
fixes the build (10.82 KB, patch)
2012-08-10 10:30 UTC, Christophe Fergeau
no flags Details | Diff

Description Alan Hamilton 2012-07-21 22:02:29 UTC
Description of problem:
Attempting to build the SRPM of libimobiledevice fails with
Error: Cython version >= 0.13.0 is required.  You have Cython version 0.16.  You should look at http://www.cython.org

Version-Release number of selected component (if applicable):
Cython-0.16-1.fc17.x86_64
libimobiledevice-1.1.4-1.fc17.x86_64

How reproducible:
Always, with the above packages. The previous release of Cython, Cython.x86_64 0:0.15.1-2.fc17, works

Additional info:
There's an upstream bug entry for this for libimobiledevice: http://libiphone.lighthouseapp.com/projects/27916/tickets/264-error-compiling-with-cython-016_rc0

The problem is an error in parsing the version string for Cython. It fails on versions that are not in the form ##.##.## . A patch is available at http://cgit.sukimashita.com/libimobiledevice.git/commit/?id=70dfe8ad1766990386f1db04bbe5a4826bcde4e5

This patch resolves the version number error, but the package still fails to compile:

Error compiling Cython file:
------------------------------------------------------------
...
        except Exception, e:
            if remapping != NULL:
                plist.plist_free(remapping)
            raise
    
    cdef inline int16_t _send(self, plist.plist_t node):
        ^
------------------------------------------------------------

mobilesync.pxi:152:9: Overriding final methods is not allowed

I'm not aware of any patches for this issue.

Comment 1 Christophe Fergeau 2012-08-10 10:19:41 UTC
http://cgit.sukimashita.com/libimobiledevice.git/commit/?id=84235e0834e57551028329723f4510e1dbe7bc11 should do the trick (testing it now)

Comment 2 Christophe Fergeau 2012-08-10 10:30:54 UTC
Created attachment 603464 [details]
fixes the build

This patch fixes the package build on koji, but I don't have commit access to libimobiledevice so can't push it.

Comment 3 Rex Dieter 2012-08-10 20:28:54 UTC
I can't extract your patch,


patch -p1 < 'attachment..'
patching file 0001-m4-Fix-parsing-of-artistic-cython-version-strings-to.patch
patch: **** malformed patch at line 54: --- a/0002-cython-Do-not-override-final-methods-as-comply-to-Cy.patch

Comment 4 Christophe Fergeau 2012-08-10 21:10:27 UTC
Try with git am maybe

Comment 5 Christophe Fergeau 2012-08-10 21:13:28 UTC
The patch only adds the 3 patches committed on 2012-05-17 from http://cgit.sukimashita.com/libimobiledevice.git/log/ and adds various BuildRequires to be able to run autoreconf -fi after applying the patches. The patches from git apply unchanged on the tarball we have in f18 and rawhide.


Note You need to log in before you can comment on or make changes to this bug.