Bug 843470 - Review Request: rubygem-sass-rails - Sass adapter for the Rails asset pipeline
Review Request: rubygem-sass-rails - Sass adapter for the Rails asset pipeline
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Bohuslav "Slavek" Kabrda
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-26 08:19 EDT by Vít Ondruch
Modified: 2012-07-27 02:49 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-07-27 02:49:00 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
bkabrda: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Vít Ondruch 2012-07-26 08:19:13 EDT
Spec URL: http://people.redhat.com/vondruch/rubygem-sass-rails.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-sass-rails-3.2.5-1.fc18.src.rpm
Description: Sass adapter for the Rails asset pipeline
Fedora Account System Username: vondruch

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4330999
Comment 1 Bohuslav "Slavek" Kabrda 2012-07-26 08:33:44 EDT
I'll take this one.
Comment 2 Bohuslav "Slavek" Kabrda 2012-07-26 08:43:25 EDT
- You should mark CHANGELOG.md as %doc, simiarly as README.markdown.
- It makes me sad when tests cannot be executed :( However I see that you are putting lots of effort in communication with the upstream about it. Since it seems there is currently no way to run the tests, it is not a blocker for me.


This package is APPROVED.
Comment 3 Vít Ondruch 2012-07-26 08:57:46 EDT
Thank you for your review.

New Package SCM Request
=======================
Package Name: rubygem-sass-rails
Short Description: Sass adapter for the Rails asset pipeline
Owners: vondruch
Branches: 
InitialCC:
Comment 4 Gwyn Ciesla 2012-07-26 09:07:16 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.