Bug 843470 - Review Request: rubygem-sass-rails - Sass adapter for the Rails asset pipeline
Summary: Review Request: rubygem-sass-rails - Sass adapter for the Rails asset pipeline
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Bohuslav "Slavek" Kabrda
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-07-26 12:19 UTC by Vít Ondruch
Modified: 2012-07-27 06:49 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-27 06:49:00 UTC
Type: ---
Embargoed:
bkabrda: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Vít Ondruch 2012-07-26 12:19:13 UTC 
Spec URL: http://people.redhat.com/vondruch/rubygem-sass-rails.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-sass-rails-3.2.5-1.fc18.src.rpm
Description: Sass adapter for the Rails asset pipeline
Fedora Account System Username: vondruch

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4330999
Comment 1 Bohuslav "Slavek" Kabrda 2012-07-26 12:33:44 UTC 
I'll take this one.
Comment 2 Bohuslav "Slavek" Kabrda 2012-07-26 12:43:25 UTC 
- You should mark CHANGELOG.md as %doc, simiarly as README.markdown.
- It makes me sad when tests cannot be executed :( However I see that you are putting lots of effort in communication with the upstream about it. Since it seems there is currently no way to run the tests, it is not a blocker for me.


This package is APPROVED.
Comment 3 Vít Ondruch 2012-07-26 12:57:46 UTC 
Thank you for your review.

New Package SCM Request
=======================
Package Name: rubygem-sass-rails
Short Description: Sass adapter for the Rails asset pipeline
Owners: vondruch
Branches: 
InitialCC:
Comment 4 Gwyn Ciesla 2012-07-26 13:07:16 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.