Bug 844589 - Review Request: perl-Devel-Declare-Parser - Higher level interface to Devel-Declare
Review Request: perl-Devel-Declare-Parser - Higher level interface to Devel-D...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Simone Caronni
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 844610
  Show dependency treegraph
 
Reported: 2012-07-31 02:47 EDT by Jitka Plesnikova
Modified: 2012-09-04 09:10 EDT (History)
3 users (show)

See Also:
Fixed In Version: perl-Devel-Declare-Parser-0.017-1.fc19
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-09-04 09:10:33 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
negativo17: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Jitka Plesnikova 2012-07-31 02:47:07 EDT
Spec URL: http://jplesnik.fedorapeople.org/perl-Devel-Declare-Parser/perl-Devel-Declare-Parser.spec
SRPM URL: http://jplesnik.fedorapeople.org/perl-Devel-Declare-Parser/perl-Devel-Declare-Parser-0.017-1.fc18.src.rpm
Description:
Devel-Declare-Parser is a higher-level API sitting on top of
Devel::Declare. It is used by Devel::Declare::Exporter to simplify
exporting of Devel::Declare magic. Writing custom parsers usualy only
requires subclassing this module and overriding a couple methods.

Fedora Account System Username: jplesnik
Comment 1 Simone Caronni 2012-09-04 04:37:47 EDT
I will review this package
Comment 2 Simone Caronni 2012-09-04 04:48:26 EDT
Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated

==== Generic ====
[x]: EXTRA Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[-]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[-]: MUST If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL5 is required
[!]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: SHOULD SourceX tarball generation or download is documented.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
     Note: Source0 (Devel-Declare-Parser-0.017.tar.gz)
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Rpmlint
-------
Checking: perl-Devel-Declare-Parser-0.017-1.fc17.src.rpm
          perl-Devel-Declare-Parser-0.017-1.fc17.noarch.rpm
perl-Devel-Declare-Parser.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers
perl-Devel-Declare-Parser.src: W: spelling-error %description -l en_US usualy -> usual, usually, usual y
perl-Devel-Declare-Parser.src: W: spelling-error %description -l en_US subclassing -> sub classing, sub-classing, subclass
perl-Devel-Declare-Parser.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers
perl-Devel-Declare-Parser.noarch: W: spelling-error %description -l en_US usualy -> usual, usually, usual y
perl-Devel-Declare-Parser.noarch: W: spelling-error %description -l en_US subclassing -> sub classing, sub-classing, subclass
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

Requires
--------
perl-Devel-Declare-Parser-0.017-1.fc17.noarch.rpm (rpmlib, GLIBC filtered):
    
    perl(:MODULE_COMPAT_5.14.2)  
    perl(B::Compiling)  
    perl(B::Compiling) >= 0.02
    perl(B::Hooks::EndOfScope)  
    perl(B::Hooks::EndOfScope) >= 0.08
    perl(Carp)  
    perl(Data::Dumper)  
    perl(Devel::BeginLift)  
    perl(Devel::Declare)  
    perl(Devel::Declare) >= 0.006
    perl(Devel::Declare::Interface)  
    perl(Devel::Declare::Parser)  
    perl(Devel::Declare::Parser::Sublike)  
    perl(Exporter)  
    perl(Scalar::Util)  
    perl(base)  
    perl(strict)  
    perl(warnings)  

Provides
--------
perl-Devel-Declare-Parser-0.017-1.fc17.noarch.rpm:
    
    perl(Devel::Declare::Interface)  
    perl(Devel::Declare::Parser) = 0.017
    perl(Devel::Declare::Parser::Codeblock)  
    perl(Devel::Declare::Parser::Emulate)  
    perl(Devel::Declare::Parser::Method)  
    perl(Devel::Declare::Parser::Sublike)  
    perl-Devel-Declare-Parser = 0.017-1.fc17

MD5-sum check
-------------
http://www.cpan.org/authors/id/E/EX/EXODIST/Devel-Declare-Parser-0.017.tar.gz :
  CHECKSUM(SHA256) this package     : f95d58f74870ca9184fc49b3d8e0b831fc9f1a7ef293a80b4b678461c792aa14
  CHECKSUM(SHA256) upstream package : f95d58f74870ca9184fc49b3d8e0b831fc9f1a7ef293a80b4b678461c792aa14
Comment 3 Simone Caronni 2012-09-04 04:56:26 EDT
Issues:

* Tests require perl(Test::More) and perl(Test::Exception) as patched in to remove perl(Test::Exception::LessClever).

* There are 3 duplicates in Requires, I think you can remove the unversioned ones; perl(B::Compiling), perl(B::Hooks::EndOfScope), perl(Devel::Declare):

$ rpm -qp --requires perl-Devel-Declare-Parser-0.017-1.fc17.noarch.rpm | uniq -c
      1 perl(:MODULE_COMPAT_5.14.2)  
      1 perl(B::Compiling)  
      1 perl(B::Compiling) >= 0.02
      1 perl(B::Hooks::EndOfScope)  
      1 perl(B::Hooks::EndOfScope) >= 0.08
      1 perl(Carp)  
      1 perl(Data::Dumper)  
      1 perl(Devel::BeginLift)  
      1 perl(Devel::Declare)  
      1 perl(Devel::Declare) >= 0.006
      1 perl(Devel::Declare::Interface)  
      1 perl(Devel::Declare::Parser)  
      1 perl(Devel::Declare::Parser::Sublike)  
      1 perl(Exporter)  
      1 perl(Scalar::Util)  
      1 perl(base)  
      1 perl(strict)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

* rpmlint issues can be ignored:

perl-Devel-Declare-Parser.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers
perl-Devel-Declare-Parser.src: W: spelling-error %description -l en_US usualy -> usual, usually, usual y
perl-Devel-Declare-Parser.src: W: spelling-error %description -l en_US subclassing -> sub classing, sub-classing, subclass
perl-Devel-Declare-Parser.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers
perl-Devel-Declare-Parser.noarch: W: spelling-error %description -l en_US usualy -> usual, usually, usual y
perl-Devel-Declare-Parser.noarch: W: spelling-error %description -l en_US subclassing -> sub classing, sub-classing, subclass
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

* license issues as well, included README says "Standard perl license" in COPYRIGHT section which is "GPL+ or Artistic".

[!]: MUST License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames
[!]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
Comment 4 Simone Caronni 2012-09-04 05:05:20 EDT
(In reply to comment #3)
> * license issues as well, included README says "Standard perl license" in
> COPYRIGHT section which is "GPL+ or Artistic".

To make it more clear, "as well" means is ok, so only the requirement issues are present.
Comment 5 Simone Caronni 2012-09-04 05:11:31 EDT
If you want to get rid of the autogenerated unversioned requirement in place of the versioned ones, you can use a filter like this:

%{?filter_setup:
%filter_from_requires           /perl(B::Compiling)/d
%filter_setup}

Otherwise you can just leave the unversioned autogenerated ones and remove the versioned ones.
Comment 6 Jitka Plesnikova 2012-09-04 07:02:08 EDT
The requires of tests have to be listed in BuildRequires. perl(Test::More) and perl(Test::Exception) are in BR. 
Requires should contains only the dependencies for modules to install (lib/)

Requires can contain both records - versioned and unversioned library. It is not issue.
Comment 7 Simone Caronni 2012-09-04 07:50:37 EDT
(In reply to comment #6)
> The requires of tests have to be listed in BuildRequires. perl(Test::More)
> and perl(Test::Exception) are in BR. 
> Requires should contains only the dependencies for modules to install (lib/)

Yes, they are, indeed. Package approved.
Comment 8 Jitka Plesnikova 2012-09-04 08:06:32 EDT
New Package SCM Request
=======================
Package Name: perl-Devel-Declare-Parser
Short Description: Higher level interface to Devel-Declare
Owners: jplesnik mmaslano ppisar psabata
Branches:
InitialCC: perl-sig
Comment 9 Gwyn Ciesla 2012-09-04 08:35:58 EDT
Git done (by process-git-requests).
Comment 10 Jitka Plesnikova 2012-09-04 09:10:33 EDT
Thank you for the review and the repository.

Note You need to log in before you can comment on or make changes to this bug.