Bug 846222 - chrony: does not check for I/O error before replacing files
Summary: chrony: does not check for I/O error before replacing files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: chrony
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miroslav Lichvar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 846000
TreeView+ depends on / blocked
 
Reported: 2012-08-07 08:24 UTC by Florian Weimer
Modified: 2012-09-18 20:03 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-09-18 20:03:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2012-08-07 08:24:08 UTC
reference.c:update_drift_file() and rtc_linux.c:write_coefs_to_file()
overwrite original file even when I/O on the temporary file fails.  Please check the return values of the write operations, or use ferror().  To be absolutely safe, you also need to call fflush() followed by fsync() directly before the fclose(), so that the new file contents isn't lost in a crash, but I'm not sure if this is really necessary here.

Comment 1 Fedora Update System 2012-09-11 18:42:16 UTC
chrony-1.27-0.5.pre1.git1ca844.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/chrony-1.27-0.5.pre1.git1ca844.fc18

Comment 2 Fedora Update System 2012-09-12 19:14:58 UTC
Package chrony-1.27-0.5.pre1.git1ca844.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing chrony-1.27-0.5.pre1.git1ca844.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-13883/chrony-1.27-0.5.pre1.git1ca844.fc18
then log in and leave karma (feedback).

Comment 3 Fedora Update System 2012-09-18 20:03:01 UTC
chrony-1.27-0.5.pre1.git1ca844.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.