Bug 848094 - [Storage][Text] Incorrect (typo) message about disks that were not removed from the system.
Summary: [Storage][Text] Incorrect (typo) message about disks that were not removed fr...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 3.1.0
Assignee: Maor
QA Contact: Leonid Natapov
URL:
Whiteboard: storage
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-14 15:06 UTC by Leonid Natapov
Modified: 2016-02-10 20:22 UTC (History)
10 users (show)

Fixed In Version: si16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-04 20:03:20 UTC
oVirt Team: Storage
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Leonid Natapov 2012-08-14 15:06:48 UTC
If we have disks that were not removed from the system while VM deletion we'll get get the following message in the event tab:

"VM test was removed. The following disks: test_Disk1,test_Disk5 were not be able to be removed and will be considered as illegal floating disks".

It is not correct to say in English  "were not be able to be removed".

Must be changed to correct message.

Also,please add the following sentence to t he message: "Please,manually remove illegal disks from from the system" as we don't want illegal disks to be presented in the system.

Comment 1 Ayal Baron 2012-08-16 10:03:06 UTC
Error message should be:
"VM X was removed. System failed to remove the following disks: ... marking them as illegal. Please try removing these disks when storage is accessible"

Comment 2 Maor 2012-08-19 16:58:43 UTC
The message is now: "VM ${VmName} was removed. but the following disks could n
ot be removed: ${DisksNames}. These disks should be removed manually, and will be considered illegal floating disks until then."

Is that satisfy?

Comment 3 Ayal Baron 2012-08-19 19:04:47 UTC
(In reply to comment #2)
> The message is now: "VM ${VmName} was removed. but the following disks could
> n
> ot be removed: ${DisksNames}. These disks should be removed manually, and
> will be considered illegal floating disks until then."
> 
> Is that satisfy?

'floating' is not clear.  Replace 'These disks.*' with 'These disks will appear in the main disks tab in illegal state, please remove manually when possible'

Comment 4 Ayal Baron 2012-08-19 19:31:10 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > The message is now: "VM ${VmName} was removed. but the following disks could
> > n
> > ot be removed: ${DisksNames}. These disks should be removed manually, and
> > will be considered illegal floating disks until then."
> > 
> > Is that satisfy?
> 
> 'floating' is not clear.  Replace 'These disks.*' with 'These disks will
> appear in the main disks tab in illegal state, please remove manually when
> possible'

Also change 'was removed' to 'has been removed'

Comment 5 Maor 2012-08-22 14:49:29 UTC
merged upstream at commit  #037929bdc997f8c0ee763bf79e565df6abc6e149

Comment 6 Allon Mureinik 2012-08-22 15:02:31 UTC
merged change-id I27ae8f3a4cd653f92760296a64ba14c4ec6c2b81

Comment 7 Leonid Natapov 2012-09-04 10:21:12 UTC
si 16.1. fixed. correct message appear.


Note You need to log in before you can comment on or make changes to this bug.