Description of problem: client_t implementation Version-Release number of selected component (if applicable): N/A How reproducible: N/A Steps to Reproduce: 1. N/A Actual results: N/A Expected results: N/A Additional info: client_t changes the (old, misnamed) server_conn structure to a "full" gluster type, including a context dict member for holding additional data for the connected client. client_t is the prerequisite for implementing multi-tenancy, among other things. The feature page for client_t is at http://www.gluster.org/community/documentation/index.php/Planning34/client_t In addition to adding client_t, the change moves the lock-table functionality from xlators/protocol/server/... to libglusterfs/... Note that context dumps are not implemented yet. They will be implemented in a later patch.
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t strawman implementation refresh) posted (#13) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t strawman implementation refresh) posted (#14) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t strawman implementation refresh) posted (#16) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t strawman implementation refresh) posted (#17) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t implementation, phase 1) posted (#18) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t implementation, phase 1) posted (#19) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t implementation, phase 1) posted (#20) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t implementation, phase 1) posted (#21) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t implementation, phase 1) posted (#22) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t implementation, phase 1) posted (#23) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t implementation, phase 1) posted (#24) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t implementation, phase 1) posted (#25) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t implementation, phase 1) posted (#26) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t implementation, phase 1) posted (#27) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/3957 (libglusterfs/client_t client_t implementation, phase 1) posted (#28) for review on master by Kaleb KEITHLEY (kkeithle)
COMMIT: http://review.gluster.org/3957 committed in master by Anand Avati (avati) ------ commit 04536e53082cdff5cd10a804502347ee83490c81 Author: Kaleb S. KEITHLEY <kkeithle> Date: Tue Sep 18 14:07:40 2012 -0400 libglusterfs/client_t client_t implementation, phase 1 Implementation of client_t The feature page for client_t is at http://www.gluster.org/community/documentation/index.php/Planning34/client_t In addition to adding libglusterfs/client_t.[ch] it also extracts/moves the locktable functionality from xlators/protocol/server to libglusterfs, where it is used; thus it may now be shared by other xlators too. This patch is large as it is. Hooking up the state dump is left to do in phase 2 of this patch set. (N.B. this change/patch-set supercedes previous change 3689, which was corrupted during a rebase. That change will be abandoned.) BUG: 849630 Change-Id: I1433743190630a6d8119a72b81439c0c4c990340 Signed-off-by: Kaleb S. KEITHLEY <kkeithle> Reviewed-on: http://review.gluster.org/3957 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Amar Tumballi <amarts>
REVIEW: http://review.gluster.org/5602 (libglusterfs: client_t phase 2, refactor to remove server_ctx and locks_ctx out of client_ctx directly and into scratch_ctx as discrete entities) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5602 (libglusterfs: client_t phase 2, refactor) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5602 (libglusterfs: client_t phase 2, refactor server_ctx and locks_ctx out) posted (#3) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5602 (libglusterfs: client_t phase 2, refactor server_ctx and locks_ctx out) posted (#4) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (libglusterfs: client_t phase 2, refactor server_ctx and locks_ctx out) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (libglusterfs: client_t phase 2, refactor server_ctx and locks_ctx out) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (libglusterfs: client_t phase 2, refactor server_ctx and locks_ctx out) posted (#3) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (libglusterfs: client_t phase 2, refactor server_ctx and locks_ctx out) posted (#4) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (libglusterfs: client_t phase 2, refactor server_ctx and locks_ctx out) posted (#5) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (libglusterfs: client_t phase 2, refactor server_ctx and locks_ctx out) posted (#6) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (libglusterfs: client_t phase 2, refactor server_ctx and locks_ctx out) posted (#7) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (libglusterfs: client_t phase 2, refactor server_ctx and locks_ctx out) posted (#8) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (libglusterfs: client_t phase 2, refactor server_ctx and locks_ctx out) posted (#9) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (libglusterfs: client_t phase 2, refactor server_ctx and locks_ctx out) posted (#10) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (libglusterfs: client_t phase 2, refactor server_ctx and locks_ctx out) posted (#11) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#12) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#13) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#14) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5852 (libglusterfs: client_t{.c,.h} includes should be pedantic) posted (#1) for review on master by Harshavardhana (harsha)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#15) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#16) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#17) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#18) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#19) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#20) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#21) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#22) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#23) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#24) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#25) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#26) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#27) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#28) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#29) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#30) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#31) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#32) for review on master by Kaleb KEITHLEY (kkeithle)
REVIEW: http://review.gluster.org/5678 (client_t: phase 2, refactor server_ctx and locks_ctx out) posted (#33) for review on master by Kaleb KEITHLEY (kkeithle)
COMMIT: http://review.gluster.org/5678 committed in master by Anand Avati (avati) ------ commit 3108d4529d57690f58027da61ac5e56a0987ed57 Author: Kaleb S. KEITHLEY <kkeithle> Date: Wed Aug 21 14:11:38 2013 -0400 client_t: phase 2, refactor server_ctx and locks_ctx out remove server_ctx and locks_ctx from client_ctx directly and store as into discrete entities in the scratch_ctx hooking up dump will be in phase 3 BUG: 849630 Change-Id: I94cea328326db236cdfdf306cb381e4d58f58d4c Signed-off-by: Kaleb S. KEITHLEY <kkeithle> Reviewed-on: http://review.gluster.org/5678 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati>
REVIEW: http://review.gluster.org/6610 (protocol/server: Change log message severity) posted (#1) for review on master by Vijay Bellur (vbellur)
COMMIT: http://review.gluster.org/6610 committed in master by Vijay Bellur (vbellur) ------ commit 2909ef3ecb5f331630460d17c56da6291c1f254b Author: Vijay Bellur <vbellur> Date: Fri Dec 27 18:00:45 2013 +0530 protocol/server: Change log message severity Change-Id: Ia6aaf8a106c26fa7118c86fadb6805d2877bb6ee BUG: 849630 Signed-off-by: Vijay Bellur <vbellur> Reviewed-on: http://review.gluster.org/6610 Reviewed-by: Pranith Kumar Karampuri <pkarampu> Tested-by: Gluster Build System <jenkins.com>
REVIEW: http://review.gluster.org/6615 (protocol/server: Change log message severity) posted (#1) for review on release-3.5 by Vijay Bellur (vbellur)
REVIEW: http://review.gluster.org/6638 (locks: various fixes) posted (#1) for review on master by Anand Avati (avati)
COMMIT: http://review.gluster.org/6615 committed in release-3.5 by Vijay Bellur (vbellur) ------ commit 1350c7193e59617f356aaae203d2170e4f38e78c Author: Vijay Bellur <vbellur> Date: Fri Dec 27 18:00:45 2013 +0530 protocol/server: Change log message severity Change-Id: Ia6aaf8a106c26fa7118c86fadb6805d2877bb6ee BUG: 849630 Signed-off-by: Vijay Bellur <vbellur> Reviewed-on: http://review.gluster.org/6610 Reviewed-by: Pranith Kumar Karampuri <pkarampu> Tested-by: Gluster Build System <jenkins.com> Reviewed-on: http://review.gluster.org/6615 Reviewed-by: Raghavendra Bhat <raghavendra>
REVIEW: http://review.gluster.org/6638 (locks: various fixes) posted (#2) for review on master by Anand Avati (avati)
REVIEW: http://review.gluster.org/6638 (locks: various fixes) posted (#3) for review on master by Anand Avati (avati)
REVIEW: http://review.gluster.org/6638 (locks: various fixes) posted (#4) for review on master by Anand Avati (avati)
REVIEW: http://review.gluster.org/6638 (locks: various fixes) posted (#5) for review on master by Anand Avati (avati)
REVIEW: http://review.gluster.org/6695 (locks: various fixes) posted (#1) for review on release-3.5 by Anand Avati (avati)
COMMIT: http://review.gluster.org/6638 committed in master by Vijay Bellur (vbellur) ------ commit aa3b01533efcd85fc1e654ac14a03ab8e1d5bbab Author: Anand Avati <avati> Date: Tue Dec 3 16:30:45 2013 -0800 locks: various fixes - implement ref/unref of entry locks (and fix bad pointer deref crashes) - code cleanup and deleted various data types - fix improper read/write lock conflict detection in entrylk - fix indefinite hang of blocked locks on disconnect - register locks in client_t synchronously, fix crashes in disconnect path Change-Id: Id273690c9111b8052139d1847060d1fb5a711924 BUG: 849630 Signed-off-by: Anand Avati <avati> Reviewed-on: http://review.gluster.org/6638 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/6695 committed in release-3.5 by Vijay Bellur (vbellur) ------ commit 8ee3846e75327bb81001607d9023fce4910fe405 Author: Anand Avati <avati> Date: Tue Dec 3 16:30:45 2013 -0800 locks: various fixes - implement ref/unref of entry locks (and fix bad pointer deref crashes) - code cleanup and deleted various data types - fix improper read/write lock conflict detection in entrylk - fix indefinite hang of blocked locks on disconnect - register locks in client_t synchronously, fix crashes in disconnect path Change-Id: Id273690c9111b8052139d1847060d1fb5a711924 BUG: 849630 Signed-off-by: Anand Avati <avati> Reviewed-on: http://review.gluster.org/6695 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/6730 (locks: set @lock->frame = NULL when lock granted) posted (#1) for review on master by Anand Avati (avati)
REVIEW: http://review.gluster.org/6730 (locks: set @lock->frame = NULL when lock is granted) posted (#2) for review on master by Anand Avati (avati)
REVIEW: http://review.gluster.org/6730 (locks: set @lock->frame = NULL when lock is granted) posted (#3) for review on master by Anand Avati (avati)
COMMIT: http://review.gluster.org/6730 committed in master by Anand Avati (avati) ------ commit 6c6c7eba87190bfe3c721faaa190949ff611405b Author: Anand Avati <avati> Date: Sun Jan 19 19:44:06 2014 -0800 locks: set @lock->frame = NULL when lock is granted This way disconnect cleanup code can differentiate which locks are granted vs blocked. Change-Id: I2a835c6865b6c804231d852953ea84eeccef35a3 BUG: 849630 Signed-off-by: Anand Avati <avati> Reviewed-on: http://review.gluster.org/6730 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra Bhat <raghavendra> Reviewed-by: Krishnan Parthasarathi <kparthas>
REVIEW: http://review.gluster.org/6762 (locks: set @lock->frame = NULL when lock is granted) posted (#1) for review on release-3.5 by Anand Avati (avati)
COMMIT: http://review.gluster.org/6762 committed in release-3.5 by Vijay Bellur (vbellur) ------ commit cd65bab3a1586e03178e8b683afea26bd324a71b Author: Anand Avati <avati> Date: Sun Jan 19 19:44:06 2014 -0800 locks: set @lock->frame = NULL when lock is granted This way disconnect cleanup code can differentiate which locks are granted vs blocked. Change-Id: I2a835c6865b6c804231d852953ea84eeccef35a3 BUG: 849630 Signed-off-by: Anand Avati <avati> Reviewed-on: http://review.gluster.org/6762 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/7224 (locks: fix unconditional op_ret success of entrylk) posted (#1) for review on master by Anand Avati (avati)
REVIEW: http://review.gluster.org/7224 (locks: fix unconditional op_ret success of entrylk) posted (#2) for review on master by Anand Avati (avati)
COMMIT: http://review.gluster.org/7224 committed in master by Anand Avati (avati) ------ commit 61f071e15572b12d12cf9764cac6456fc2df5ff3 Author: Anand Avati <avati> Date: Sat Mar 8 12:50:47 2014 -0800 locks: fix unconditional op_ret success of entrylk Bug introduced in recent refactoring. op_ret of entrylk() was always getting set to 0 even though second locker wouldn't have gotten a lock. This was resulting in multiple contenders to get locks granted at the same time. Change-Id: I99c187a9285fb80cc500b38f468f2ebda7048cab Signed-off-by: Anand Avati <avati> BUG: 849630 Reviewed-on: http://review.gluster.org/7224 Reviewed-by: Pranith Kumar Karampuri <pkarampu> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle>
REVIEW: http://review.gluster.org/7232 (locks: fix unconditional op_ret success of entrylk) posted (#1) for review on release-3.5 by Pranith Kumar Karampuri (pkarampu)
COMMIT: http://review.gluster.org/7232 committed in release-3.5 by Vijay Bellur (vbellur) ------ commit 18ad6f2dc7b8254ef718de6311f7344b28e99797 Author: Anand Avati <avati> Date: Sat Mar 8 12:50:47 2014 -0800 locks: fix unconditional op_ret success of entrylk Bug introduced in recent refactoring. op_ret of entrylk() was always getting set to 0 even though second locker wouldn't have gotten a lock. This was resulting in multiple contenders to get locks granted at the same time. BUG: 849630 Change-Id: I130d521407afee15de59f270b59687d41982fb29 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/7232 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>