Bug 851376 - [PATCH] Bump to latest upstream
[PATCH] Bump to latest upstream
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: rubygem-addressable (Show other bugs)
18
All Linux
unspecified Severity unspecified
: ---
: ---
Assigned To: Shawn Starr
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-23 20:22 EDT by Bobby Powers
Modified: 2012-08-24 21:55 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-08-24 21:55:36 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
patch to bump to latest upstream (1.69 KB, patch)
2012-08-23 20:22 EDT, Bobby Powers
no flags Details | Diff
srpm that builds for me (90.03 KB, application/x-rpm)
2012-08-24 16:11 EDT, Bobby Powers
no flags Details

  None (edit)
Description Bobby Powers 2012-08-23 20:22:13 EDT
Created attachment 606720 [details]
patch to bump to latest upstream

I've got a project which wants a newer version of this.  Let me know if there are any questions or concerns - it builds in mock fine and seems to do the trick.
Comment 1 Shawn Starr 2012-08-24 15:32:59 EDT
Which Fedora release? Fedora 17 gives me errors in mock when doing %check

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.2SSuQx
+ umask 022
+ cd /builddir/build/BUILD
~/build/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2 ~/build/BUILD/rubygem-addressable-2.3.2
+ cd rubygem-addressable-2.3.2
+ unset DISPLAY
+ pushd ./usr/share/gems/gems/addressable-2.3.2
+ rspec spec/
/usr/share/ruby/uri/http.rb:22:in `<module:URI>': superclass mismatch for class HTTP (TypeError)
        from /usr/share/ruby/uri/http.rb:12:in `<top (required)>'
        from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
        from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
        from /usr/share/ruby/uri.rb:107:in `<top (required)>'
        from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
        from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
        from /usr/share/ruby/net/http.rb:23:in `<top (required)>'
        from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
        from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
        from /builddir/build/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/spec/addressable/net_http_compat_spec.rb:18:in `<top (required)>'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/configuration.rb:698:in `load'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/configuration.rb:698:in `block in load_spec_files'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/configuration.rb:698:in `map'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/configuration.rb:698:in `load_spec_files'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/command_line.rb:22:in `run'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/runner.rb:80:in `run_in_process'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/runner.rb:69:in `run'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/runner.rb:10:in `block in autorun'
error: Bad exit status from /var/tmp/rpm-tmp.2SSuQx (%check)
    Bad exit status from /var/tmp/rpm-tmp.2SSuQx (%check)
RPM build errors:
Child return code was: 1
Comment 2 Shawn Starr 2012-08-24 15:40:57 EDT
Same for Fedora 18, need to look into it
Comment 3 Bobby Powers 2012-08-24 16:10:41 EDT
I only tested building on and for f18.  I'll attach my srpm, but I've verified the diff is the same

[bpowers@fina rubygem-addressable]$ rpm -qa | egrep '^rpm-[[:digit:]]|^yum-[[:digit:]]|^mock-[[:digit:]]'
mock-1.1.26-2.fc18.noarch
rpm-4.10.0-6.fc18.x86_64
yum-3.4.3-33.fc18.noarch
Comment 4 Bobby Powers 2012-08-24 16:11:19 EDT
Created attachment 606953 [details]
srpm that builds for me

super weird.  I'd like to know what I'm doing wrong :)
Comment 5 Shawn Starr 2012-08-24 16:19:40 EDT
[spstarr@segfault Downloads]$ rpmbuild --rebuild rubygem-addressable-2.3.2-1.fc19.src.rpm 
Installing rubygem-addressable-2.3.2-1.fc19.src.rpm
warning: user bpowers does not exist - using root
warning: group bpowers does not exist - using root
warning: user bpowers does not exist - using root
warning: group bpowers does not exist - using root
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.IluUWm
+ umask 022
+ cd /home/spstarr/rpmbuild/BUILD
+ LANG=C
+ export LANG
+ unset DISPLAY
+ cd /home/spstarr/rpmbuild/BUILD
+ rm -rf rubygem-addressable-2.3.2
+ /usr/bin/mkdir -p rubygem-addressable-2.3.2
+ cd rubygem-addressable-2.3.2
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ gem install -V --local --install-dir ./usr/share/gems --force --rdoc --ri /home/spstarr/rpmbuild/SOURCES/addressable-2.3.2.gem
Installing gem addressable-2.3.2
Using local gem /home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/cache/addressable-2.3.2.gem
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/lib/addressable/idna/native.rb
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/lib/addressable/idna/pure.rb
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/lib/addressable/idna.rb
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/lib/addressable/template.rb
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/lib/addressable/uri.rb
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/lib/addressable/version.rb
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/spec/addressable/idna_spec.rb
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/spec/addressable/net_http_compat_spec.rb
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/spec/addressable/template_spec.rb
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/spec/addressable/uri_spec.rb
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/data/unicode.data
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/tasks/clobber.rake
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/tasks/gem.rake
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/tasks/git.rake
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/tasks/metrics.rake
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/tasks/rspec.rake
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/tasks/rubyforge.rake
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/tasks/yard.rake
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/website/index.html
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/CHANGELOG.md
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/Gemfile
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/LICENSE.txt
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/Rakefile
/home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/README.md
Successfully installed addressable-2.3.2
1 gem installed
Installing ri documentation for addressable-2.3.2...
rdoc --ri --op /home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/doc/addressable-2.3.2/ri --main README.md lib README.md --title addressable-2.3.2 Documentation
Parsing sources...
unable to convert U+2014 from UTF-8 to US-ASCII for lib/addressable/uri.rb, skipping
unable to convert "\xC2" to UTF-8 in conversion from ASCII-8BIT to UTF-8 to US-ASCII for README.md, skipping


Generating RI format into /home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/doc/addressable-2.3.2/ri...

Files:       7

Classes:     8 ( 0 undocumented)
Modules:     3 ( 3 undocumented)
Constants:  46 (44 undocumented)
Attributes:  4 ( 0 undocumented)
Methods:    18 ( 3 undocumented)

Total:      79 (50 undocumented)
 36.71% documented

Elapsed: 0.6s
Installing RDoc documentation for addressable-2.3.2...
rdoc --op /home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/doc/addressable-2.3.2/rdoc --main README.md lib README.md --title addressable-2.3.2 Documentation
Parsing sources...
unable to convert U+2014 from UTF-8 to US-ASCII for lib/addressable/uri.rb, skipping
unable to convert "\xC2" to UTF-8 in conversion from ASCII-8BIT to UTF-8 to US-ASCII for README.md, skipping


Generating Darkfish format into /home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/doc/addressable-2.3.2/rdoc...

Files:       7

Classes:     8 ( 0 undocumented)
Modules:     3 ( 3 undocumented)
Constants:  46 (44 undocumented)
Attributes:  4 ( 0 undocumented)
Methods:    18 ( 3 undocumented)

Total:      79 (50 undocumented)
 36.71% documented

Elapsed: 0.7s
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.0WEevC
+ umask 022
+ cd /home/spstarr/rpmbuild/BUILD
+ cd rubygem-addressable-2.3.2
+ LANG=C
+ export LANG
+ unset DISPLAY
+ exit 0
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.uMf44R
+ umask 022
+ cd /home/spstarr/rpmbuild/BUILD
+ '[' /home/spstarr/rpmbuild/BUILDROOT/rubygem-addressable-2.3.2-1.fc18.x86_64 '!=' / ']'
+ rm -rf /home/spstarr/rpmbuild/BUILDROOT/rubygem-addressable-2.3.2-1.fc18.x86_64
++ dirname /home/spstarr/rpmbuild/BUILDROOT/rubygem-addressable-2.3.2-1.fc18.x86_64
+ mkdir -p /home/spstarr/rpmbuild/BUILDROOT
+ mkdir /home/spstarr/rpmbuild/BUILDROOT/rubygem-addressable-2.3.2-1.fc18.x86_64
+ cd rubygem-addressable-2.3.2
+ LANG=C
+ export LANG
+ unset DISPLAY
+ mkdir -p /home/spstarr/rpmbuild/BUILDROOT/rubygem-addressable-2.3.2-1.fc18.x86_64/usr/share/gems
+ cp -a ./usr /home/spstarr/rpmbuild/BUILDROOT/rubygem-addressable-2.3.2-1.fc18.x86_64/
+ xargs -n 1 sed -i -e '/^#!\/usr\/bin\/env ruby/d'
+ find ./usr/share/gems/gems/addressable-2.3.2/Rakefile ./usr/share/gems/gems/addressable-2.3.2/lib ./usr/share/gems/gems/addressable-2.3.2/spec -type f
+ find ./usr/share/gems/gems/addressable-2.3.2/Rakefile ./usr/share/gems/gems/addressable-2.3.2/lib ./usr/share/gems/gems/addressable-2.3.2/spec -type f
+ xargs chmod 0644
+ /usr/lib/rpm/find-debuginfo.sh --strict-build-id -m --run-dwz --dwz-low-mem-die-limit 10000000 --dwz-max-die-limit 110000000 /home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2
+ '[' noarch = noarch ']'
+ case "${QA_CHECK_RPATHS:-}" in
+ /usr/lib/rpm/check-buildroot
+ /usr/lib/rpm/redhat/brp-compress
+ /usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip
+ /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1
+ /usr/lib/rpm/redhat/brp-python-hardlink
+ /usr/lib/rpm/redhat/brp-java-repack-jars
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.EN3bc8
+ umask 022
+ cd /home/spstarr/rpmbuild/BUILD
+ cd rubygem-addressable-2.3.2
+ unset DISPLAY
+ pushd ./usr/share/gems/gems/addressable-2.3.2
~/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2 ~/rpmbuild/BUILD/rubygem-addressable-2.3.2
+ rspec spec/
/usr/share/ruby/uri/http.rb:22:in `<module:URI>': superclass mismatch for class HTTP (TypeError)
        from /usr/share/ruby/uri/http.rb:12:in `<top (required)>'
        from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
        from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
        from /usr/share/ruby/uri.rb:107:in `<top (required)>'
        from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
        from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
        from /usr/share/ruby/net/http.rb:23:in `<top (required)>'
        from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
        from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
        from /home/spstarr/rpmbuild/BUILD/rubygem-addressable-2.3.2/usr/share/gems/gems/addressable-2.3.2/spec/addressable/net_http_compat_spec.rb:18:in `<top (required)>'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/configuration.rb:698:in `load'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/configuration.rb:698:in `block in load_spec_files'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/configuration.rb:698:in `map'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/configuration.rb:698:in `load_spec_files'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/command_line.rb:22:in `run'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/runner.rb:80:in `run_in_process'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/runner.rb:69:in `run'
        from /usr/share/gems/gems/rspec-core-2.8.0/lib/rspec/core/runner.rb:10:in `block in autorun'
error: Bad exit status from /var/tmp/rpm-tmp.EN3bc8 (%check)


RPM build errors:
    user bpowers does not exist - using root
    group bpowers does not exist - using root
    user bpowers does not exist - using root
    group bpowers does not exist - using root
    Bad exit status from /var/tmp/rpm-tmp.EN3bc8 (%check)
Comment 6 Shawn Starr 2012-08-24 16:38:30 EDT
Ah I see why..

There's a Namespace conflict in the spec test:

--- uri_spec.rb 2012-08-24 16:33:43.184191256 -0400
+++ uri_spec.rb.old     2012-08-24 16:33:29.969356464 -0400
@@ -42,7 +42,7 @@ if !"".respond_to?("force_encoding")
 end
 
 module URI
-  class HTTP
+  class AddressableHTTP
     def initialize(uri)
       @uri = uri
     end
@@ -463,7 +463,7 @@ end
 describe Addressable::URI, "when parsed from something that looks " +
     "like a URI object" do
   it "should parse without error" do
-    uri = Addressable::URI.parse(URI::HTTP.new("http://example.com/"))
+    uri = Addressable::URI.parse(URI::AddressableHTTP.new("http://example.com/"))
     (lambda do
       Addressable::URI.parse(uri)
     end).should_not raise_error


and there exists a conflict but I would have thought even just changing the Module namespace name would fix this, I don't see any 'require "uri"' which would directly put the namespace in conflict with Ruby's uri handling.

[spstarr@segfault addressable-2.3.2]$ rspec spec
..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Finished in 1.16 seconds
1074 examples, 0 failures
Comment 7 Shawn Starr 2012-08-24 16:43:37 EDT
the patch should say .new, but regardless, that fixes issue, Which version of Ruby do you have installed?

I have: ruby-1.9.3.194-15.fc18.x86_64
Comment 8 Bobby Powers 2012-08-24 17:01:12 EDT
different version! maybe thats it?
ruby-1.9.3.194-16.fc18.x86_64
Comment 9 Shawn Starr 2012-08-24 17:13:30 EDT
Tried -16 makes no difference either.

I'm not sure why this builds for you in your mock environment also. It fails when I switched my mock from 17 -> 18 even

Just from mock alone the minimum dependencies will be the same for both of us. 

are you on IRC right now?
Comment 10 Bobby Powers 2012-08-24 17:29:19 EDT
yup, nteon in #fedora
Comment 11 Shawn Starr 2012-08-24 18:01:15 EDT
http://koji.fedoraproject.org/koji/taskinfo?taskID=4421011

Yeah, same error on koji scratch, so I'm not crazy. We can fix this in .spec to patch the Class name conflict
Comment 13 Shawn Starr 2012-08-24 21:55:36 EDT
This is in rawhide now.

Note You need to log in before you can comment on or make changes to this bug.