Bug 852100 - Both inactive and Maintenance statuses are displayed as 'Inactive' for storage domain
Summary: Both inactive and Maintenance statuses are displayed as 'Inactive' for storag...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.1.0
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
: 3.1.0
Assignee: Asaf Shakarchi
QA Contact: Leonid Natapov
URL:
Whiteboard: storage
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-27 15:44 UTC by Laszlo Hornyak
Modified: 2016-02-10 18:39 UTC (History)
14 users (show)

Fixed In Version: SI20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-04 19:59:15 UTC
oVirt Team: Storage
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Laszlo Hornyak 2012-08-27 15:44:25 UTC
A storage domain in the DB is in Maintenance status, however in the storage domain view of the webadmin it appears as 'Inactive'. This is misleading both for users and developers.

Comment 1 Laszlo Hornyak 2012-08-27 15:44:58 UTC
see https://bugzilla.redhat.com/812621

Comment 2 Asaf Shakarchi 2012-09-10 11:38:48 UTC
Currently in main storage domain table we display the 'Shared Status' per storage domain, which is the cross Data-Centers status.

This field value set to 2 (InActive) when (any) storage domain is in maintenance mode,

Lazlo, I believe you looked at the 'status' field and not the 'storage_domain_shared_status' which is what we display in the UI.

One option is to avoid using the shared status for non iso storage domains,
Another option could be to avoid displaying any value on the shared status for non iso storage domains,



Ayal, please assist with describing the appropriate behaviour,


Thanks.

Comment 3 Ayal Baron 2012-09-12 12:23:37 UTC
(In reply to comment #2)
> Currently in main storage domain table we display the 'Shared Status' per
> storage domain, which is the cross Data-Centers status.
> 
> This field value set to 2 (InActive) when (any) storage domain is in
> maintenance mode,
> 
> Lazlo, I believe you looked at the 'status' field and not the
> 'storage_domain_shared_status' which is what we display in the UI.
> 
> One option is to avoid using the shared status for non iso storage domains,

this would probably be easiest.

> Another option could be to avoid displaying any value on the shared status
> for non iso storage domains,
> 
> 
> 
> Ayal, please assist with describing the appropriate behaviour,
> 
> 
> Thanks.

Comment 4 Asaf Shakarchi 2012-09-13 09:44:29 UTC
Okay, then for non ISO storage domain, maybe we can write 'Status per Data-Center'
If this is not self explanatory, then we can explain it in more details with a tooltip.

Please ack the status string or provide an alternative,
If tooltip is required please provide the description,

Thanks.

Comment 5 Ayal Baron 2012-09-13 12:26:06 UTC
(In reply to comment #4)
> Okay, then for non ISO storage domain, maybe we can write 'Status per
> Data-Center'
> If this is not self explanatory, then we can explain it in more details with
> a tooltip.
> 
> Please ack the status string or provide an alternative,
> If tooltip is required please provide the description,
> 
> Thanks.

Why? the cross data-center status is the same as the single data-center status seeing as there is a single data-center.  1 data center is a private case of multiple.

What would happen with an ISO domain that is only attached to 1 dc? it's exactly the same.

Comment 6 Asaf Shakarchi 2012-09-20 15:16:13 UTC
Since there's no reason to display the shared cross datacenter status for non ISO domains, I go with the following solution:

For non ISO domain, display the single status of the domain,
For ISO domains, continue displaying the shared cross dc status.

Comment 7 Asaf Shakarchi 2012-09-27 17:02:39 UTC
Patch submitted according to the suggested logic in comment #6:

http://gerrit.ovirt.org/#/c/8258/

Comment 8 Allon Mureinik 2012-10-03 11:29:55 UTC
Merged change id I3faa0d0504520513ce0c565b2476779d0362edfb

Comment 9 Leonid Natapov 2012-10-14 12:21:54 UTC
si20. non ISO domains displaying the single status now.


Note You need to log in before you can comment on or make changes to this bug.