Description of problem: rubygem-stickshift-node is running restorecon against /var/lib/stickshift and shouldn't be. This is probably causing issues that will need to be corrected with rhc-restorecon. This is also the cause of the over 1 hour update runs on the c9 nodes. So it'd be nice if the fix was to remove this completely. Version-Release number of selected component (if applicable): rubygem-stickshift-node-0.15.7-1.el6_3.noarch How reproducible: Very Steps to Reproduce: 1. Run: rpm -q rubygem-stickshift-node --scripts 2. Notice the line that says this: restorecon -r /var/lib/stickshift Actual results: It's running restorecon against /var/lib/stickshift Expected results: It should not be running restorecon against /var/lib/stickshift
@kraman made that fix to add /var/lib/stickshift as part of commit bf9987ce -- not sure what the reason was -- the log says to get devenv running. Krishna? bf9987ce (Krishna Raman 2012-03-07 10:06:02 -0800 123) /sbin/restorecon /var/lib/stickshift || : bf9987ce (Krishna Raman 2012-03-07 10:06:02 -0800 126) /sbin/restorecon /var/lib/stickshift/.httpd.d/ || : Heads up, am going to be removing those 2 lines in the next couple of days -- afaics, its not needed but feel free to holler if you feel otherwise!!
Was added for the Origin to fix file permissions. If you remove it, will need to add a restorecon to ss-setup-node script.
Ok -- will do that -- remove it from node.spec and add it to the ss-setup-node script.
Fixed with pull requests: https://github.com/openshift/li/pull/344 https://github.com/openshift/crankcase/pull/456
Tested on devenv_2119 Steps: 1. Run: rpm -q rubygem-stickshift-node --scripts [root@ip-10-190-85-85 ~]# rpm -q rubygem-stickshift-node --scripts postinstall scriptlet (using /bin/sh): echo "/usr/bin/ss-trap-user" >> /etc/shells restorecon -r /var/lib/stickshift # copying this file in the post hook so that this file can be replaced by rhc-node # copy this file only if it doesn't already exist if ! [ -f /etc/stickshift/resource_limits.conf ]; then cp -f /etc/stickshift/resource_limits.template /etc/stickshift/resource_limits.conf fi 2. Run: rpm -q rhc-node --scripts There is no line as: "restorecon -r /var/lib/stickshift" Since reproduced the problem, assign it back
Good catch Hou. So Thomas, looks like it was being done a couple of times. Ugg, we seem to have these scattered across the place ... One more fix in pull request: https://github.com/openshift/crankcase/pull/460
Move it to ON_QA since https://github.com/openshift/crankcase/pull/460 is merged
Verified on devenv_2132 Steps: 1. Run: rpm -q rubygem-stickshift-node --scripts 2. Run: rpm -q rhc-node --scripts Result: There is no line as: "restorecon -r /var/lib/stickshift"
Verified on devenv_2140 Steps: 1. Run: rpm -q rubygem-stickshift-node --scripts postinstall scriptlet (using /bin/sh): echo "/usr/bin/ss-trap-user" >> /etc/shells # copying this file in the post hook so that this file can be replaced by rhc-node # copy this file only if it doesn't already exist if ! [ -f /etc/stickshift/resource_limits.conf ]; then cp -f /etc/stickshift/resource_limits.template /etc/stickshift/resource_limits.conf fi 2. Run: rpm -q rhc-node --scripts No restorecon against /var/lib/stickshift There is no line as: "restorecon -r /var/lib/stickshift" So move this bug to verified.