Bug 854500 - ovirt-engine-backend: Need to rephrase "oVirt" value for VM origin field
Summary: ovirt-engine-backend: Need to rephrase "oVirt" value for VM origin field
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Omer Frenkel
QA Contact: Oded Ramraz
URL:
Whiteboard: virt
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-09-05 08:14 UTC by Oded Ramraz
Modified: 2012-12-04 20:08 UTC (History)
10 users (show)

Fixed In Version: si18
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
oVirt Team: ---
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Oded Ramraz 2012-09-05 08:14:56 UTC 
Description of problem:

Need to rephrase "oVirt"  value for VM origin field . Should be RHEV or something similar . 


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 lpeer 2012-09-05 08:25:41 UTC 
Oded - what is the origin of the VM?
We have 4 possible values for origin: RHEV(0), VMWARE(1),XEN(2),OVIRT(3);

If the VM was exported in RHEV and the origin says ovirt that's a bug we should fix otherwise it should stay ovirt.
Comment 2 Itamar Heim 2012-09-05 08:27:29 UTC 
as part of branding, need to update the config in rhev for origin to be rhev...

    /**
     * The origin type to be used for VM and VM template creation
     */
    @TypeConverterAttribute(String.class)
    @DefaultValueAttribute("OVIRT")
    OriginType(336),
Comment 3 lpeer 2012-09-05 08:35:24 UTC 
The value is taken from config.sql (the java code is used as default in case the value is not in the DB), but it looks like it is OVIRT there as well, so need to fix that.
Comment 4 Doron Fediuck 2012-09-05 08:52:05 UTC 
(In reply to comment #3)
> The value is taken from config.sql (the java code is used as default in case
> the value is not in the DB), but it looks like it is OVIRT there as well, so
> need to fix that.

Why not fix both, so code is consistent with the DB scripts?
Comment 5 Omer Frenkel 2012-09-05 09:18:42 UTC 
(In reply to comment #4)
> (In reply to comment #3)
> > The value is taken from config.sql (the java code is used as default in case
> > the value is not in the DB), but it looks like it is OVIRT there as well, so
> > need to fix that.
> 
> Why not fix both, so code is consistent with the DB scripts?

it doesn't really matter, code defaults are used only if value is missing in db,
which should not happen.
Comment 7 Omer Frenkel 2012-09-05 09:38:47 UTC 
https://gerrit.eng.lab.tlv.redhat.com/#/c/1850/
Comment 13 Oded Ramraz 2012-09-13 09:40:11 UTC 
Verified si18:

Origin fields value is now RHEV instead of oVirt
Note You need to log in before you can comment on or make changes to this bug.