Bug 854946 - "rhc domain" shouldn't allow invalid rhlogin
"rhc domain" shouldn't allow invalid rhlogin
Status: CLOSED WONTFIX
Product: OpenShift Origin
Classification: Red Hat
Component: Command Line Interface (Show other bugs)
2.x
Unspecified Unspecified
medium Severity medium
: ---
: ---
Assigned To: Clayton Coleman
libra bugs
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-06 07:10 EDT by jizhao
Modified: 2015-05-14 22:04 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-09-06 14:06:54 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description jizhao 2012-09-06 07:10:51 EDT
Description of problem:
Provide an invalid rhlogin to "rhc domain create". Although the domain creation isn't successful actually, the client always returns success. Other "rhc domain" commands also fail to check rhlogin.

Version-Release number of selected component (if applicable):
rhc-0.98.8-1.el6_3.noarch
devenv_2119

How reproducible:
Always

Steps to Reproduce:
1.rhc domain create testdomain -l '3333$$%##' -p redhat -d
2.rhc domain update testdomain -l '3333$$%##' -p redhat -d
3.rhc domain show -l '3333$$%##' -p redhat -d
  
Actual results:
1. Creating domain with namespace 'testdomain'

D, [2012-09-06T18:56:21.924126 #21793] DEBUG -- : Connecting to https://ec2-23-22-207-35.compute-1.amazonaws.com/broker/rest/api
D, [2012-09-06T18:56:25.725695 #21793] DEBUG -- : Adding domain testdomain
D, [2012-09-06T18:56:28.158867 #21793] DEBUG -- : Response did not include a message from server
RESULT:
Success!
You may now create an application using the 'rhc app create' command


2. D, [2012-09-06T19:01:02.040504 #22046] DEBUG -- : Connecting to https://ec2-23-22-207-35.compute-1.amazonaws.com/broker/rest/api
D, [2012-09-06T19:01:06.046971 #22046] DEBUG -- : Getting all domains
D, [2012-09-06T19:01:08.070428 #22046] DEBUG -- : Response did not include a message from server
No domains are registered to the user 3333$$%##. Please use 'rhc domain create' to create one.


3.D, [2012-09-06T19:01:39.525784 #22124] DEBUG -- : Connecting to https://ec2-23-22-207-35.compute-1.amazonaws.com/broker/rest/api
D, [2012-09-06T19:01:43.227048 #22124] DEBUG -- : Getting all domains
D, [2012-09-06T19:01:45.220865 #22124] DEBUG -- : Response did not include a message from server
No domain exists.  You can use 'rhc domain create' to create a namespace for applications.


Expected results:
OpenShift login may not contain any of these characters: (\") ($) (^) (<) (>) (|) (%) (/) (;) (:) (,) (\) (*) (=) (~)


Additional info:
Comment 1 John (J5) Palmieri 2012-09-06 14:01:09 EDT
rhc domain create testdomain -l '3333$$%##' -p redhat

Creating domain with namespace 'testdomain'

Not authenticated

I don't see an issue with the current code.  Perhaps it is a server issue?
Comment 2 John (J5) Palmieri 2012-09-06 14:06:54 EDT
Actually, if you are running against dev there is no authentication by default so I think this is a wontfix.  The auth server itself doesn't allow anyone to sign up with weird characters so you can't authenticate on production.

If we care about this the server should throw an error instead of not sending back data.

Note You need to log in before you can comment on or make changes to this bug.