Red Hat Bugzilla – Bug 860128
RFE-[WebTrans] Save Failed should return human readable message instead of error code
Last modified: 2013-02-25 22:46:16 EST
Description of problem:
In WebTrans, connection lost causes "Save Failed: 0"
Howerer The number here is not very intuitive, as they are likely be misinterpreted as either row number or some unexpected error.
It will be better to show something like "Save Failed: Lost Connection"
Version-Release number of selected component (if applicable):
Zanata version 1.8.0-SNAPSHOT (20120925-0027)
Steps to Reproduce:
0. (Optional) install a web site blocker add-on on your browser
1. Visit any document
2. Copy source on any row
3. Disconnect the web site by either disable the network, or block the zanata server.
4. Save the copied text
Save Failed: 0
Save Failed: Lost Coonection
It's covered by bug 873483
Fix only apply in 2.1-SNAPSHOT but not 2.0.3-SNAPSHOT.
Patrick, is this supposed to be a duplicate of bug 873483? That bug was verified for 2.0, so how can it be broken here?
If the code change was not in fact applied to the release branch, I think we should just change the Target Release to 2.1.
committed into release:
(In reply to comment #3)
> Patrick, is this supposed to be a duplicate of bug 873483? That bug was
> verified for 2.0, so how can it be broken here?
> If the code change was not in fact applied to the release branch, I think we
> should just change the Target Release to 2.1.
bug 873483 is for general RPC exception handling. This bug is specific to save failure. Before above commit, save failure notification still shows: "Save failure: 0" among other notification suggesting connection has lost. Now it should simply state: "Save failure: id 123"
Verified in Zanata version 2.0.3-SNAPSHOT (20121127-1451)