Bug 863769 - Review Request: cura-tools - set of CLI tools for cura providers
Review Request: cura-tools - set of CLI tools for cura providers
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Mario Blättermann
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2012-10-07 06:33 EDT by Peter Hatina
Modified: 2016-05-31 21:31 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2012-10-10 04:51:02 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mario.blaettermann: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Peter Hatina 2012-10-07 06:33:36 EDT
Spec URL: http://phatina.fedorapeople.org/rpms/cura-tools.spec
SRPM URL: http://phatina.fedorapeople.org/rpms/cura-tools-0.1-1.fc17.src.rpm
Description: cura-tools is a set of command line tools for Cura-providers.
Fedora Account System Username: phatina

rpmlint output:
$ rpmlint ../RPMS/noarch/cura-tools-0.1-1.fc17.noarch.rpm 
cura-tools.noarch: W: no-manual-page-for-binary fmci-ip.py
cura-tools.noarch: W: no-manual-page-for-binary fmci-service.py
cura-tools.noarch: W: no-manual-page-for-binary fmci-user.py
cura-tools.noarch: W: no-manual-page-for-binary fmci-power.py
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

ad man-pages: Currently, there is no plan for manual pages.

$ rpmlint ../SRPMS/cura-tools-0.1-1.fc17.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Comment 1 Mario Blättermann 2012-10-07 07:13:41 EDT
The pywbem package needs python2 recursively, that's why you should drop python2 from Requires.

The folder %{python_sitelib}/fmci/ is not owned by your package. Remove the * to let the folder and its content owned. Or is there any requirement which provides this folder?
Comment 2 Mario Blättermann 2012-10-07 07:22:42 EDT
Scratch build:

It fails for f18. From build.log:

checking python module: pywbem... no
configure: error: failed to find required module pywbem

This means, pywbem has to be in BuildRequires instead of Requires. In this case, you can drop all the stuff in Requires completely because the runtime dependencies are checked automatically by rpm due to system calls during the build.
Comment 3 Peter Hatina 2012-10-07 07:26:22 EDT
Removed python2 dependency.
Fixed fmci directory ownership.
Fixed BuildRequires.

Spec URL: http://phatina.fedorapeople.org/rpms/cura-tools.spec
SRPM URL: http://phatina.fedorapeople.org/rpms/cura-tools-0.1-2.fc17.src.rpm
Comment 4 Mario Blättermann 2012-10-07 07:28:19 EDT
As far as I can see, you are not in the package maintainers group. In this case please add FE-NEEDSPONSOR in the "Blocks" field.
Comment 5 Peter Hatina 2012-10-07 07:39:04 EDT
I have been sponsored by jwrdegoede some time ago.
Can be seen in this request: https://bugzilla.redhat.com/show_bug.cgi?id=703719
Comment 6 Mario Blättermann 2012-10-07 08:26:08 EDT
New scratch build:

$ rpmlint -i -v *
cura-tools.src: I: checking
cura-tools.src: I: checking-url http://fedorahosted.org/cura/ (timeout 10 seconds)
cura-tools.src: I: checking-url http://fedorahosted.org/released/cura-tools/cura-tools-0.1.tar.gz (timeout 10 seconds)
cura-tools.noarch: I: checking
cura-tools.noarch: I: checking-url http://fedorahosted.org/cura/ (timeout 10 seconds)
cura-tools.noarch: W: no-manual-page-for-binary fmci-ip.py
Each executable in standard binary directories should have a man page.

cura-tools.noarch: W: no-manual-page-for-binary fmci-service.py
Each executable in standard binary directories should have a man page.

cura-tools.noarch: W: no-manual-page-for-binary fmci-user.py
Each executable in standard binary directories should have a man page.

cura-tools.noarch: W: no-manual-page-for-binary fmci-power.py
Each executable in standard binary directories should have a man page.

Looks fine now.


[+] OK
[.] OK, not applicable
[X] needs work

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual license.
[+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
    $ sha256sum *
    b17b09eee81a6b1e7e8a5012288fa42a554251aeefaf6ec2242e66bab63ec551  cura-tools-0.1.tar.gz
    b17b09eee81a6b1e7e8a5012288fa42a554251aeefaf6ec2242e66bab63ec551  cura-tools-0.1.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)
[+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: Development files must be in a -devel package.
[.] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
[.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.
[+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses Mock anyway).
[.] SHOULD: The package should compile and build into binary rpms on all supported architectures.
[.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity.
[.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
[.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.
[.] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.




$ rpm -qpR cu*h.rpm
python(abi) = 2.7
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

The package pywbem hasn't been picked up automatically... Is it needed at runtime, or just for the build process? If you need it at runtime, please add it again to Requires. Because you are the upstream author, you should know about it ;)
Comment 7 Peter Hatina 2012-10-07 08:35:09 EDT
New Package SCM Request
Package Name: cura-tools
Short Description: Set of CLI tools for cura providers
Owners: phatina
Branches: f18
Comment 8 Peter Hatina 2012-10-07 08:36:56 EDT
(In reply to comment #7)
> New Package SCM Request
> =======================
> Package Name: cura-tools
> Short Description: Set of CLI tools for cura providers
> Owners: phatina
> Branches: f18
> InitialCC:

Branches: f17 f18
Comment 9 Jason Tibbitts 2012-10-08 12:40:22 EDT
Git done (by process-git-requests).
Comment 10 Peter Hatina 2012-10-08 15:44:57 EDT
Package Change Request
Package Name: cura-tools
New Branches: f17
Owners: phatina
Comment 11 Gwyn Ciesla 2012-10-09 07:14:27 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.