Created attachment 626131 [details] exaple of entered 'junk' ntp servers Description of problem: You can setup junk ntp servers. Some form of improved input validation seems to be needed. For example, one can set a % as an npt server. One can also set a ' ' single space as an ntp server, and a ' ' double space, ' ' triple space, etc as an ntp server. it does not look good (and i am afraid that i won't work). Version-Release number of selected component (if applicable): F18b tc3 How reproducible: always Steps to Reproduce: 1. goto date and time, enter new ntp servers with junk data Actual results: it seems to validate only again duplicated entries. Expected results: better validation Additional info:
Created attachment 626133 [details] got stuck after accepting previous entries anaconda got stuck
After some time in that state it returned to the map. So, and the junk hostnames remained.
Created attachment 644983 [details] [anaconda-18.29-1] screenshot showing black rectangle instead of NTP server configuration dialog I had this already written up as a new bug before I discovered that Reartes had filed this bug ... Description of problem: In the Date & Time spoke, if a very long NTP server name is added, the NTP server configuration dialog is replaced by a black rectangle. See attached screenshot. Version-Release number of selected component (if applicable): anaconda-18.29-1 Fedora-18-Beta-TC8-x86_64-Live-Desktop.iso How reproducible: Always. Steps to Reproduce: 1. Accept English as install language. 2. Click Date & Time. 3. Click gear icon to display NTP server configuration dialog. 4. In the server name text box, hold the 'x' key for about 60 seconds. 5. Click '+' button. Actual results: Black rectangle (see attached screenshot). Cannot return to Date & Time spoke by clicking or by pressing enter. Can return to Date & Time spoke by pressing escape. There appears to one white pixel at the upper left corner of the black rectangle. Expected results: NTP server configuration dialog is displayed. Additional info: Tested with: $ qemu-kvm -m 2048 -hda f18-test-2.img -cdrom ~/xfr/fedora/F18/F18-Beta/TC8/Fedora-18-Beta-TC8-x86_64-Live-Desktop.iso -usb -vga qxl -boot menu=on -usbdevice mouse
If you enter '中文 (台湾)' as an NTP server name, you get a traceback while writing the kickstart file: Bug 876293 - UnicodeDecodeError: 'ascii' codec can't decode byte 0xe4 in position 56: ordinal not in range(128)
Patch for checking if given string is a valid hostname posted to anaconda-patches.
[master] Check NTP servers for validity https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-November/002243.html Thanks.
(In reply to comment #5) > Patch for checking if given string is a valid hostname posted to > anaconda-patches. Pushed.
pykickstart-1.99.22-1.fc18, anaconda-18.35-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/FEDORA-2012-19380/pykickstart-1.99.22-1.fc18,anaconda-18.35-1.fc18
Package pykickstart-1.99.22-1.fc18, anaconda-18.35-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing pykickstart-1.99.22-1.fc18 anaconda-18.35-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-19380/pykickstart-1.99.22-1.fc18,anaconda-18.35-1.fc18 then log in and leave karma (feedback).
pykickstart-1.99.22-1.fc18, anaconda-18.35-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.